| Message ID | 20230703230534.997525-2-javierm@redhat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Allow disabling all native fbdev drivers and only keeping DRM emulation | expand |
Hi Javier, On Tue, Jul 4, 2023 at 1:05 AM Javier Martinez Canillas <javierm@redhat.com> wrote: > The drivers in this subsystem are for character-based LCD displays, which > can fall into the same category of the DRM/KMS and fbdev drivers that are > located under the "Graphics support" menu. Add auxdisplay there as well. > > Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Thanks for your patch! > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -30,6 +30,8 @@ if HAS_IOMEM > config HAVE_FB_ATMEL > bool > > +source "drivers/auxdisplay/Kconfig" This is inside the "if HAS_IOMEM" section, while there was no such limitation before. > + > source "drivers/char/agp/Kconfig" > > source "drivers/gpu/vga/Kconfig" Gr{oetje,eeting}s, Geert
Geert Uytterhoeven <geert@linux-m68k.org> writes: Hello Geert, > Hi Javier, > > On Tue, Jul 4, 2023 at 1:05 AM Javier Martinez Canillas > <javierm@redhat.com> wrote: >> The drivers in this subsystem are for character-based LCD displays, which >> can fall into the same category of the DRM/KMS and fbdev drivers that are >> located under the "Graphics support" menu. Add auxdisplay there as well. >> >> Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > > Thanks for your patch! > >> --- a/drivers/video/Kconfig >> +++ b/drivers/video/Kconfig >> @@ -30,6 +30,8 @@ if HAS_IOMEM >> config HAVE_FB_ATMEL >> bool >> >> +source "drivers/auxdisplay/Kconfig" > > This is inside the "if HAS_IOMEM" section, while there was no > such limitation before. > Gah, I missed that. Thanks a lot for pointing it out. If I move the source outside of the if block, are you OK with this patch? I think Thomas is correct and would make sense to put the character-based drivers next to the DRM and fbdev drivers since all these are for display.
Hi Javier, On Tue, Jul 4, 2023 at 9:54 AM Javier Martinez Canillas <javierm@redhat.com> wrote: > Geert Uytterhoeven <geert@linux-m68k.org> writes: > > On Tue, Jul 4, 2023 at 1:05 AM Javier Martinez Canillas > > <javierm@redhat.com> wrote: > >> The drivers in this subsystem are for character-based LCD displays, which > >> can fall into the same category of the DRM/KMS and fbdev drivers that are > >> located under the "Graphics support" menu. Add auxdisplay there as well. > >> > >> Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> > >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > > > > Thanks for your patch! > > > >> --- a/drivers/video/Kconfig > >> +++ b/drivers/video/Kconfig > >> @@ -30,6 +30,8 @@ if HAS_IOMEM > >> config HAVE_FB_ATMEL > >> bool > >> > >> +source "drivers/auxdisplay/Kconfig" > > > > This is inside the "if HAS_IOMEM" section, while there was no > > such limitation before. > > > > Gah, I missed that. Thanks a lot for pointing it out. > > If I move the source outside of the if block, are you OK with this patch? > > I think Thomas is correct and would make sense to put the character-based > drivers next to the DRM and fbdev drivers since all these are for display. Yes, makes sense to me. Gr{oetje,eeting}s, Geert
Geert Uytterhoeven <geert@linux-m68k.org> writes: > Hi Javier, [...] >> > This is inside the "if HAS_IOMEM" section, while there was no >> > such limitation before. >> > >> >> Gah, I missed that. Thanks a lot for pointing it out. >> >> If I move the source outside of the if block, are you OK with this patch? >> >> I think Thomas is correct and would make sense to put the character-based >> drivers next to the DRM and fbdev drivers since all these are for display. > > Yes, makes sense to me. > Good to know. Thanks! > Gr{oetje,eeting}s,
diff --git a/drivers/Kconfig b/drivers/Kconfig index 514ae6b24cb2..496ca02ee18f 100644 --- a/drivers/Kconfig +++ b/drivers/Kconfig @@ -129,8 +129,6 @@ source "drivers/dma-buf/Kconfig" source "drivers/dca/Kconfig" -source "drivers/auxdisplay/Kconfig" - source "drivers/uio/Kconfig" source "drivers/vfio/Kconfig" diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 8b2b9ac37c3d..acf02863ac7d 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -30,6 +30,8 @@ if HAS_IOMEM config HAVE_FB_ATMEL bool +source "drivers/auxdisplay/Kconfig" + source "drivers/char/agp/Kconfig" source "drivers/gpu/vga/Kconfig"
The drivers in this subsystem are for character-based LCD displays, which can fall into the same category of the DRM/KMS and fbdev drivers that are located under the "Graphics support" menu. Add auxdisplay there as well. Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> --- (no changes since v1) drivers/Kconfig | 2 -- drivers/video/Kconfig | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-)