| Message ID | 20231019101348.22076-2-anonolitunya@gmail.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | staging: sm750fb: Remove unused return values from functions | expand |
On Thu, Oct 19, 2023 at 01:13:36PM +0300, Dorcas AnonoLitunya wrote: > Modifies the return type of display_control_adjust_sm750le() > to void from unsigned long as the return value is being ignored in > all subsequent function calls. > > This improves code readability and maintainability. > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> > --- > drivers/staging/sm750fb/ddk750_mode.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) This patch doesn't apply against my latest branch. Please rebase it and resend. thanks, greg k-h
On 21/10/2023 13:01, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2023 at 01:13:36PM +0300, Dorcas AnonoLitunya wrote: >> Modifies the return type of display_control_adjust_sm750le() >> to void from unsigned long as the return value is being ignored in >> all subsequent function calls. >> >> This improves code readability and maintainability. >> >> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> >> --- >> drivers/staging/sm750fb/ddk750_mode.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) > This patch doesn't apply against my latest branch. Please rebase it and > resend. > > thanks, > > greg k-h Hi Greg, Sorry for the delay. Was occupied on the project starter tasks. I have rebased the patch and resent it. Thanks! Dorcas
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index bcdd291d25c9..83ace6cc9583 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -13,7 +13,7 @@ * HW only supports 7 predefined pixel clocks, and clock select is * in bit 29:27 of Display Control register. */ -static unsigned long +static void display_control_adjust_sm750le(struct mode_parameter *mode_param, unsigned long disp_control) { @@ -70,8 +70,6 @@ display_control_adjust_sm750le(struct mode_parameter *mode_param, disp_control |= DISPLAY_CTRL_CLOCK_PHASE; poke32(CRT_DISPLAY_CTRL, disp_control); - - return disp_control; } /* only timing related registers will be programed */
Modifies the return type of display_control_adjust_sm750le() to void from unsigned long as the return value is being ignored in all subsequent function calls. This improves code readability and maintainability. Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> --- drivers/staging/sm750fb/ddk750_mode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)