| Message ID | 20231115102954.7102-12-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | fbdev: Modularize helpers for struct fb_ops | expand |
Thomas Zimmermann <tzimmermann@suse.de> writes: > The picolcd_fb driver operates on system memory. Mark the framebuffer > accordingly. Helpers operating on the framebuffer memory will test > for the presence of this flag. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: "Bruno Prémont" <bonbons@linux-vserver.org> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Cc: linux-input@vger.kernel.org > --- > drivers/hid/hid-picolcd_fb.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
On Thu, 16 Nov 2023 11:27:55 +0100 Javier Martinez Canillas wrote: > Thomas Zimmermann <tzimmermann@suse.de> writes: > > > The picolcd_fb driver operates on system memory. Mark the framebuffer > > accordingly. Helpers operating on the framebuffer memory will test > > for the presence of this flag. > > > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: "Bruno Prémont" <bonbons@linux-vserver.org> > > Cc: Jiri Kosina <jikos@kernel.org> > > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > Cc: linux-input@vger.kernel.org > > --- > > drivers/hid/hid-picolcd_fb.c | 1 + > > 1 file changed, 1 insertion(+) > > > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
On Wed, 15 Nov 2023, Thomas Zimmermann wrote: > The picolcd_fb driver operates on system memory. Mark the framebuffer > accordingly. Helpers operating on the framebuffer memory will test > for the presence of this flag. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: "Bruno Prémont" <bonbons@linux-vserver.org> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Cc: linux-input@vger.kernel.org Acked-by: Jiri Kosina <jkosina@suse.cz> I guess this will go in as one series together, right?
Hi Am 21.11.23 um 09:42 schrieb Jiri Kosina: > On Wed, 15 Nov 2023, Thomas Zimmermann wrote: > >> The picolcd_fb driver operates on system memory. Mark the framebuffer >> accordingly. Helpers operating on the framebuffer memory will test >> for the presence of this flag. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> Cc: "Bruno Prémont" <bonbons@linux-vserver.org> >> Cc: Jiri Kosina <jikos@kernel.org> >> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> >> Cc: linux-input@vger.kernel.org > > Acked-by: Jiri Kosina <jkosina@suse.cz> > > I guess this will go in as one series together, right? Yes. I intend to move all this through the DRM trees. Best regards Thomas >
diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c index a4dccdcda26fc..d7dddd99d325e 100644 --- a/drivers/hid/hid-picolcd_fb.c +++ b/drivers/hid/hid-picolcd_fb.c @@ -505,6 +505,7 @@ int picolcd_init_framebuffer(struct picolcd_data *data) dev_err(dev, "can't get a free page for framebuffer\n"); goto err_nomem; } + info->flags |= FBINFO_VIRTFB; info->screen_buffer = fbdata->bitmap; info->fix.smem_start = (unsigned long)fbdata->bitmap; memset(fbdata->vbitmap, 0xff, PICOLCDFB_SIZE);
The picolcd_fb driver operates on system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: "Bruno Prémont" <bonbons@linux-vserver.org> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: linux-input@vger.kernel.org --- drivers/hid/hid-picolcd_fb.c | 1 + 1 file changed, 1 insertion(+)