| Message ID | 20240210053938.30558-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | fbdev/sh7760fb: allow modular build | expand |
Randy Dunlap <rdunlap@infradead.org> writes: > There is no reason to prohibit sh7760fb from being built as a > loadable module as suggested by Geert, so change the config symbol > from bool to tristate to allow that and change the FB dependency as > needed. > > Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y") > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Helge Deller <deller@gmx.de> > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > --- > drivers/video/fbdev/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Javier Martinez Canillas <javierm@redhat.com>
On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote: > There is no reason to prohibit sh7760fb from being built as a > loadable module as suggested by Geert, so change the config symbol > from bool to tristate to allow that and change the FB dependency as > needed. > > Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y") > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Helge Deller <deller@gmx.de> > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > --- > drivers/video/fbdev/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -1645,8 +1645,8 @@ config FB_COBALT > select FB_IOMEM_HELPERS > > config FB_SH7760 > - bool "SH7760/SH7763/SH7720/SH7721 LCDC support" > - depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ > + tristate "SH7760/SH7763/SH7720/SH7721 LCDC support" > + depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ > || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721) > select FB_IOMEM_HELPERS > help Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Adrian
Hi, Will someone be merging this patch? thanks. On 2/10/24 1:31 AM, John Paul Adrian Glaubitz wrote: > On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote: >> There is no reason to prohibit sh7760fb from being built as a >> loadable module as suggested by Geert, so change the config symbol >> from bool to tristate to allow that and change the FB dependency as >> needed. >> >> Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y") >> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Thomas Zimmermann <tzimmermann@suse.de> >> Cc: Javier Martinez Canillas <javierm@redhat.com> >> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> >> Cc: Sam Ravnborg <sam@ravnborg.org> >> Cc: Helge Deller <deller@gmx.de> >> Cc: linux-fbdev@vger.kernel.org >> Cc: dri-devel@lists.freedesktop.org >> --- >> drivers/video/fbdev/Kconfig | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig >> --- a/drivers/video/fbdev/Kconfig >> +++ b/drivers/video/fbdev/Kconfig >> @@ -1645,8 +1645,8 @@ config FB_COBALT >> select FB_IOMEM_HELPERS >> >> config FB_SH7760 >> - bool "SH7760/SH7763/SH7720/SH7721 LCDC support" >> - depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ >> + tristate "SH7760/SH7763/SH7720/SH7721 LCDC support" >> + depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ >> || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721) >> select FB_IOMEM_HELPERS >> help > > Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > > Adrian >
On 4/10/24 06:54, Randy Dunlap wrote: > Hi, > > Will someone be merging this patch? I've just added it to the fbdev git tree. Thanks! Helge > > thanks. > > On 2/10/24 1:31 AM, John Paul Adrian Glaubitz wrote: >> On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote: >>> There is no reason to prohibit sh7760fb from being built as a >>> loadable module as suggested by Geert, so change the config symbol >>> from bool to tristate to allow that and change the FB dependency as >>> needed. >>> >>> Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y") >>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> >>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>> Cc: Thomas Zimmermann <tzimmermann@suse.de> >>> Cc: Javier Martinez Canillas <javierm@redhat.com> >>> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> >>> Cc: Sam Ravnborg <sam@ravnborg.org> >>> Cc: Helge Deller <deller@gmx.de> >>> Cc: linux-fbdev@vger.kernel.org >>> Cc: dri-devel@lists.freedesktop.org >>> --- >>> drivers/video/fbdev/Kconfig | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig >>> --- a/drivers/video/fbdev/Kconfig >>> +++ b/drivers/video/fbdev/Kconfig >>> @@ -1645,8 +1645,8 @@ config FB_COBALT >>> select FB_IOMEM_HELPERS >>> >>> config FB_SH7760 >>> - bool "SH7760/SH7763/SH7720/SH7721 LCDC support" >>> - depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ >>> + tristate "SH7760/SH7763/SH7720/SH7721 LCDC support" >>> + depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ >>> || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721) >>> select FB_IOMEM_HELPERS >>> help >> >> Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> >> >> Adrian >> >
Hi Randy,
On Tue, 2024-04-09 at 21:54 -0700, Randy Dunlap wrote:
> Will someone be merging this patch?
Shall I pick it up through my tree?
Adrian
On Wed, 2024-04-10 at 15:17 +0200, Helge Deller wrote: > On 4/10/24 06:54, Randy Dunlap wrote: > > Hi, > > > > Will someone be merging this patch? > > I've just added it to the fbdev git tree. Ah, good. Then I can drop it from my queue again. Adrian
diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1645,8 +1645,8 @@ config FB_COBALT select FB_IOMEM_HELPERS config FB_SH7760 - bool "SH7760/SH7763/SH7720/SH7721 LCDC support" - depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ + tristate "SH7760/SH7763/SH7720/SH7721 LCDC support" + depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721) select FB_IOMEM_HELPERS help
There is no reason to prohibit sh7760fb from being built as a loadable module as suggested by Geert, so change the config symbol from bool to tristate to allow that and change the FB dependency as needed. Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y") Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Javier Martinez Canillas <javierm@redhat.com> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Helge Deller <deller@gmx.de> Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/video/fbdev/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)