| Message ID | 20240326223825.4084412-2-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | enabled -Wformat-truncation for clang | expand |
Hi Arnd, Thank you for the patch. On Tue, Mar 26, 2024 at 11:38:00PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The name of the overlay does not fit into the fixed-length field: > > drivers/video/fbdev/sh_mobile_lcdcfb.c:1577:2: error: 'snprintf' will always be truncated; specified size is 16, but format string expands to at least 25 > > Make it short enough by changing the string. > > Fixes: c5deac3c9b22 ("fbdev: sh_mobile_lcdc: Implement overlays support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c > index eb2297b37504..d35d2cf99998 100644 > --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > @@ -1575,7 +1575,7 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl) > */ > info->fix = sh_mobile_lcdc_overlay_fix; > snprintf(info->fix.id, sizeof(info->fix.id), > - "SH Mobile LCDC Overlay %u", ovl->index); > + "SHMobile ovl %u", ovl->index); > info->fix.smem_start = ovl->dma_handle; > info->fix.smem_len = ovl->fb_size; > info->fix.line_length = ovl->pitch;
On 3/26/24 23:38, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The name of the overlay does not fit into the fixed-length field: > > drivers/video/fbdev/sh_mobile_lcdcfb.c:1577:2: error: 'snprintf' will always be truncated; specified size is 16, but format string expands to at least 25 > > Make it short enough by changing the string. > > Fixes: c5deac3c9b22 ("fbdev: sh_mobile_lcdc: Implement overlays support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> applied to fbdev git tree. Thanks! Helge > --- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c > index eb2297b37504..d35d2cf99998 100644 > --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > @@ -1575,7 +1575,7 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl) > */ > info->fix = sh_mobile_lcdc_overlay_fix; > snprintf(info->fix.id, sizeof(info->fix.id), > - "SH Mobile LCDC Overlay %u", ovl->index); > + "SHMobile ovl %u", ovl->index); > info->fix.smem_start = ovl->dma_handle; > info->fix.smem_len = ovl->fb_size; > info->fix.line_length = ovl->pitch;
diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index eb2297b37504..d35d2cf99998 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -1575,7 +1575,7 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl) */ info->fix = sh_mobile_lcdc_overlay_fix; snprintf(info->fix.id, sizeof(info->fix.id), - "SH Mobile LCDC Overlay %u", ovl->index); + "SHMobile ovl %u", ovl->index); info->fix.smem_start = ovl->dma_handle; info->fix.smem_len = ovl->fb_size; info->fix.line_length = ovl->pitch;