| Message ID | 20240617142746.51885-2-shiva_kr@riseup.net (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | staging: fbtft: Remove unnecessary parentheses | expand |
On Mon, Jun 17, 2024 at 07:57:47PM +0530, Shiva Kiran K wrote: > Remove unnecessary parentheses in `if` statements. > Reported by checkpatch.pl As per the many times this came up in the past (see the mailing list archives), checkpatch is wrong here. sorry, greg k-h
On Mon, Jun 17, 2024 at 07:57:47PM +0530, Shiva Kiran K wrote: > Remove unnecessary parentheses in `if` statements. > Reported by checkpatch.pl > > Signed-off-by: Shiva Kiran K <shiva_kr@riseup.net> > --- > drivers/staging/fbtft/fb_ili9320.c | 2 +- > drivers/staging/fbtft/fb_ra8875.c | 2 +- > drivers/staging/fbtft/fbtft-bus.c | 2 +- > drivers/staging/fbtft/fbtft-core.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c > index 0be7c2d51..409b54cc5 100644 > --- a/drivers/staging/fbtft/fb_ili9320.c > +++ b/drivers/staging/fbtft/fb_ili9320.c > @@ -37,7 +37,7 @@ static int init_display(struct fbtft_par *par) > devcode = read_devicecode(par); > fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code: 0x%04X\n", > devcode); > - if ((devcode != 0x0000) && (devcode != 0x9320)) > + if (devcode != 0x0000 && devcode != 0x9320) > dev_warn(par->info->device, > "Unrecognized Device code: 0x%04X (expected 0x9320)\n", > devcode); > diff --git a/drivers/staging/fbtft/fb_ra8875.c b/drivers/staging/fbtft/fb_ra8875.c > index 398bdbf53..ce305a0be 100644 > --- a/drivers/staging/fbtft/fb_ra8875.c > +++ b/drivers/staging/fbtft/fb_ra8875.c > @@ -50,7 +50,7 @@ static int init_display(struct fbtft_par *par) > > par->fbtftops.reset(par); > > - if ((par->info->var.xres == 320) && (par->info->var.yres == 240)) { > + if (par->info->var.xres == 320 && par->info->var.yres == 240) { > /* PLL clock frequency */ > write_reg(par, 0x88, 0x0A); > write_reg(par, 0x89, 0x02); > diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c > index 3d422bc11..ab903c938 100644 > --- a/drivers/staging/fbtft/fbtft-bus.c > +++ b/drivers/staging/fbtft/fbtft-bus.c > @@ -85,7 +85,7 @@ void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...) > if (len <= 0) > return; > > - if (par->spi && (par->spi->bits_per_word == 8)) { > + if (par->spi && par->spi->bits_per_word == 8) { > /* we're emulating 9-bit, pad start of buffer with no-ops > * (assuming here that zero is a no-op) > */ > diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c > index c8d52c63d..64babfe3a 100644 > --- a/drivers/staging/fbtft/fbtft-core.c > +++ b/drivers/staging/fbtft/fbtft-core.c > @@ -666,7 +666,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display, > txbuflen = 0; > > #ifdef __LITTLE_ENDIAN > - if ((!txbuflen) && (bpp > 8)) > + if (!txbuflen && bpp > 8) > txbuflen = PAGE_SIZE; /* need buffer for byteswapping */ > #endif > > -- > 2.45.2 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You sent a patch that has been sent multiple times in the past few days, and is identical to ones that has been recently rejected. Please always look at the mailing list traffic to determine if you are duplicating other people's work. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c index 0be7c2d51..409b54cc5 100644 --- a/drivers/staging/fbtft/fb_ili9320.c +++ b/drivers/staging/fbtft/fb_ili9320.c @@ -37,7 +37,7 @@ static int init_display(struct fbtft_par *par) devcode = read_devicecode(par); fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code: 0x%04X\n", devcode); - if ((devcode != 0x0000) && (devcode != 0x9320)) + if (devcode != 0x0000 && devcode != 0x9320) dev_warn(par->info->device, "Unrecognized Device code: 0x%04X (expected 0x9320)\n", devcode); diff --git a/drivers/staging/fbtft/fb_ra8875.c b/drivers/staging/fbtft/fb_ra8875.c index 398bdbf53..ce305a0be 100644 --- a/drivers/staging/fbtft/fb_ra8875.c +++ b/drivers/staging/fbtft/fb_ra8875.c @@ -50,7 +50,7 @@ static int init_display(struct fbtft_par *par) par->fbtftops.reset(par); - if ((par->info->var.xres == 320) && (par->info->var.yres == 240)) { + if (par->info->var.xres == 320 && par->info->var.yres == 240) { /* PLL clock frequency */ write_reg(par, 0x88, 0x0A); write_reg(par, 0x89, 0x02); diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c index 3d422bc11..ab903c938 100644 --- a/drivers/staging/fbtft/fbtft-bus.c +++ b/drivers/staging/fbtft/fbtft-bus.c @@ -85,7 +85,7 @@ void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...) if (len <= 0) return; - if (par->spi && (par->spi->bits_per_word == 8)) { + if (par->spi && par->spi->bits_per_word == 8) { /* we're emulating 9-bit, pad start of buffer with no-ops * (assuming here that zero is a no-op) */ diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index c8d52c63d..64babfe3a 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -666,7 +666,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display, txbuflen = 0; #ifdef __LITTLE_ENDIAN - if ((!txbuflen) && (bpp > 8)) + if (!txbuflen && bpp > 8) txbuflen = PAGE_SIZE; /* need buffer for byteswapping */ #endif
Remove unnecessary parentheses in `if` statements. Reported by checkpatch.pl Signed-off-by: Shiva Kiran K <shiva_kr@riseup.net> --- drivers/staging/fbtft/fb_ili9320.c | 2 +- drivers/staging/fbtft/fb_ra8875.c | 2 +- drivers/staging/fbtft/fbtft-bus.c | 2 +- drivers/staging/fbtft/fbtft-core.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)