| Message ID | 20241004014349.435006-1-qianqiang.liu@163.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | fbdev: clps711x-fb: Remove dead code | expand |
Hi Am 04.10.24 um 03:43 schrieb Qianqiang Liu: > The code can never be reached: unregister_framebuffer(info); > > Fixes: 36462ac19308 ("fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev") > Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/video/fbdev/clps711x-fb.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c > index 9e3df1df5ac4..b57134bc63e7 100644 > --- a/drivers/video/fbdev/clps711x-fb.c > +++ b/drivers/video/fbdev/clps711x-fb.c > @@ -332,8 +332,6 @@ static int clps711x_fb_probe(struct platform_device *pdev) > > return 0; > > - unregister_framebuffer(info); > - This used to be code for error rollback, but is now unused. Thanks for fixing the issue. Best regards Thomas > out_fb_dealloc_cmap: > regmap_update_bits(cfb->syscon, SYSCON_OFFSET, SYSCON1_LCDEN, 0); > fb_dealloc_cmap(&info->cmap);
diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c index 9e3df1df5ac4..b57134bc63e7 100644 --- a/drivers/video/fbdev/clps711x-fb.c +++ b/drivers/video/fbdev/clps711x-fb.c @@ -332,8 +332,6 @@ static int clps711x_fb_probe(struct platform_device *pdev) return 0; - unregister_framebuffer(info); - out_fb_dealloc_cmap: regmap_update_bits(cfb->syscon, SYSCON_OFFSET, SYSCON1_LCDEN, 0); fb_dealloc_cmap(&info->cmap);
The code can never be reached: unregister_framebuffer(info); Fixes: 36462ac19308 ("fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev") Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com> --- drivers/video/fbdev/clps711x-fb.c | 2 -- 1 file changed, 2 deletions(-)