From patchwork Sun Jul 29 21:14:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Tobias Schandinat X-Patchwork-Id: 1252941 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 4A5A83FC33 for ; Sun, 29 Jul 2012 21:14:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414Ab2G2VOh (ORCPT ); Sun, 29 Jul 2012 17:14:37 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:41816 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753540Ab2G2VOh (ORCPT ); Sun, 29 Jul 2012 17:14:37 -0400 Received: (qmail invoked by alias); 29 Jul 2012 21:14:35 -0000 Received: from dslb-092-074-255-101.pools.arcor-ip.net (EHLO [192.168.0.9]) [92.74.255.101] by mail.gmx.net (mp027) with SMTP; 29 Jul 2012 23:14:35 +0200 X-Authenticated: #10250065 X-Provags-ID: V01U2FsdGVkX1/Q61d/FhPQkxJ5/8mDXA+WRPvVM5tYqpSJaR0sYy RB5/IbiakjeIPw Message-ID: <5015A7B9.90200@gmx.de> Date: Sun, 29 Jul 2012 21:14:33 +0000 From: Florian Tobias Schandinat User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120613 Icedove/3.0.11 MIME-Version: 1.0 To: "Manjunathappa, Prakash" CC: linux-fbdev@vger.kernel.org, davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH] video: da8xx-fb: do clock reset of revision 2 LCDC before enabling References: <1342799471-10729-1-git-send-email-prakash.pm@ti.com> In-Reply-To: <1342799471-10729-1-git-send-email-prakash.pm@ti.com> X-Y-GMX-Trusted: 0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 07/20/2012 03:51 PM, Manjunathappa, Prakash wrote: > As in specification software reset should be applied for several > cycles before bringing it out of reset. Without this patch > particularly during suspend and resume clock reset is not guaranteed > to happen. > > Signed-off-by: Manjunathappa, Prakash Applied. But it would be better if you made the patch dependencies clear, as I didn't consider some of your patches mature enough for this merge window. Now I had to figure out why my final build failed and applied the patch below. Best regards, Florian Tobias Schandinat --- commit a0239073fd75489d25575cf3aaf71ab55b416020 Author: Florian Tobias Schandinat Date: Sun Jul 29 16:47:40 2012 +0000 da8xx-fb: fix compile issue due to missing include Signed-off-by: Florian Tobias Schandinat > --- > drivers/video/da8xx-fb.c | 12 ++++++++---- > 1 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c > index 3d2d0d1..4440292 100644 > --- a/drivers/video/da8xx-fb.c > +++ b/drivers/video/da8xx-fb.c > @@ -262,10 +262,18 @@ static inline void lcd_enable_raster(void) > { > u32 reg; > > + /* Put LCDC in reset for several cycles */ > + if (lcd_revision == LCD_VERSION_2) > + /* Write 1 to reset LCDC */ > + lcdc_write(LCD_CLK_MAIN_RESET, LCD_CLK_RESET_REG); > + mdelay(1); > + > /* Bring LCDC out of reset */ > if (lcd_revision == LCD_VERSION_2) > lcdc_write(0, LCD_CLK_RESET_REG); > + mdelay(1); > > + /* Above reset sequence doesnot reset register context */ > reg = lcdc_read(LCD_RASTER_CTRL_REG); > if (!(reg & LCD_RASTER_ENABLE)) > lcdc_write(reg | LCD_RASTER_ENABLE, LCD_RASTER_CTRL_REG); > @@ -279,10 +287,6 @@ static inline void lcd_disable_raster(void) > reg = lcdc_read(LCD_RASTER_CTRL_REG); > if (reg & LCD_RASTER_ENABLE) > lcdc_write(reg & ~LCD_RASTER_ENABLE, LCD_RASTER_CTRL_REG); > - > - if (lcd_revision == LCD_VERSION_2) > - /* Write 1 to reset LCDC */ > - lcdc_write(LCD_CLK_MAIN_RESET, LCD_CLK_RESET_REG); > } > > static void lcd_blit(int load_mode, struct da8xx_fb_par *par) -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c index ca9943a..7ae9d53 100644 --- a/drivers/video/da8xx-fb.c +++ b/drivers/video/da8xx-fb.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include