| Message ID | 502367ddf6d79b7b343b3165ad54cb9e2d4713db.1369843969.git.michal.simek@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, May 29, 2013 at 06:12:56PM +0200, Michal Simek wrote: > From: Michal Simek <monstr@monstr.eu> > > DTB is always big-endian that's why is necessary > to convert it. > > Signed-off-by: Michal Simek <monstr@monstr.eu> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > drivers/video/xilinxfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c > index af0b4fd..5af341e 100644 > --- a/drivers/video/xilinxfb.c > +++ b/drivers/video/xilinxfb.c > @@ -428,7 +428,7 @@ static int xilinxfb_of_probe(struct platform_device *op) > * interface and initialize the tft_access accordingly. > */ > p = (u32 *)of_get_property(op->dev.of_node, "xlnx,dcr-splb-slave-if", NULL); You should consider using 'of_property_read_u32() (or one of its other variants for arrays, strings, etc). That already implicitly does the endian conversion. Sören -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c index af0b4fd..5af341e 100644 --- a/drivers/video/xilinxfb.c +++ b/drivers/video/xilinxfb.c @@ -428,7 +428,7 @@ static int xilinxfb_of_probe(struct platform_device *op) * interface and initialize the tft_access accordingly. */ p = (u32 *)of_get_property(op->dev.of_node, "xlnx,dcr-splb-slave-if", NULL); - tft_access = p ? *p : 0; + tft_access = p ? be32_to_cpup(p) : 0; /* * Fill the resource structure if its direct PLB interface