From patchwork Tue May 26 07:35:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Schocher X-Patchwork-Id: 6478491 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 96ADCC0020 for ; Tue, 26 May 2015 07:35:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B3F862046F for ; Tue, 26 May 2015 07:35:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C23D92042C for ; Tue, 26 May 2015 07:35:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751339AbbEZHfz (ORCPT ); Tue, 26 May 2015 03:35:55 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:53671 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143AbbEZHfy (ORCPT ); Tue, 26 May 2015 03:35:54 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3lwnBs2P0Mz3hjDN; Tue, 26 May 2015 09:35:33 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3lwnBs1gkBzvdWc; Tue, 26 May 2015 09:35:33 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id jx_bHer7lw4c; Tue, 26 May 2015 09:35:31 +0200 (CEST) X-Auth-Info: t26PBQoJeEH+f6pxxHl4Ni3iJx3LbIq6YwVMqJ5Nvso= Received: from [192.168.0.110] (87-97-127-21.pool.invitel.hu [87.97.127.21]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 26 May 2015 09:35:31 +0200 (CEST) Message-ID: <55642243.5000205@denx.de> Date: Tue, 26 May 2015 09:35:31 +0200 From: Heiko Schocher Reply-To: hs@denx.de Organization: DENX Software Engineering User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Tomi Valkeinen , "linux-kernel@vger.kernel.org" , Linux Fbdev development list , Jean-Christophe Plagniol-Villard Subject: Re: [RFC PATCH] video/logo: introduce new system state for checking if logos are freed References: <1430896145-8887-1-git-send-email-hs@denx.de> <5562B9CE.7050807@ti.com> <5563EEF9.3080901@denx.de> <556418A9.8010603@ti.com> <55641E1E.9010607@denx.de> In-Reply-To: Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello Geert, Am 26.05.2015 09:25, schrieb Geert Uytterhoeven: > On Tue, May 26, 2015 at 9:17 AM, Heiko Schocher wrote: >> 4) draw only one logo even on multicores ... why must every core draw >> a logo? Currently each core draws the logo, and on a system with more >> than 4 cores, I think this looks not really good ... > > I don't think each core draws a logo. They're all drawn from fbcon_switch(). Hmm... I have here an imx6dl based system, and it draws two logos when booting... I can prevent this two logos, if I do: >> Hmm... I do not really have a lot experience in this area ... but why >> is the logo only drawed when booting? Is there nothing like a "redraw" >> of it? > > When do you want to redraw it? On VC switch (it's drawn on the first call > only, hence it disappears if you switch VC and back)? > Until when should it be redrawn? I don;t know, it was just a question ... If this is not possible, we do not need to cover such a case, good! bye, Heiko > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 0705d88..e907ab9 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -664,8 +672,7 @@ int fb_show_logo(struct fb_info *info, int rotate) { int y; - y = fb_show_logo_line(info, rotate, fb_logo.logo, 0, - num_online_cpus()); + y = fb_show_logo_line(info, rotate, fb_logo.logo, 0, 1); y = fb_show_extra_logos(info, y, rotate); return y;