| Message ID | 585dc03acb4016bba910e7d15fec3ef4f0aec5b0.1646683502.git.geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
| Series | drm: Add support for low-color frame buffer formats | expand |
On Mon, 7 Mar 2022 21:52:43 +0100 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Traditionally, the first channel has been called the "red" channel, but > the fourcc values for single-channel "red" formats can also be used for > other light-on-dark displays, like grayscale. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > RFC, as I have no immediate need for these formats. > > v2: > - New. > --- > include/uapi/drm/drm_fourcc.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index 457ed39cc48f08e1..f0187cf20e4619d2 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -104,16 +104,16 @@ extern "C" { > #define DRM_FORMAT_C4 fourcc_code('C', '4', ' ', ' ') /* [7:0] C0:C1 4:4 two pixels/byte */ > #define DRM_FORMAT_C8 fourcc_code('C', '8', ' ', ' ') /* [7:0] C 8 one pixel/byte */ > > -/* 8 bpp Red */ > +/* 8 bpp Red (or generic light-on-dark) */ > #define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') /* [7:0] R */ > > -/* 10 bpp Red */ > +/* 10 bpp Red (or generic light-on-dark) */ > #define DRM_FORMAT_R10 fourcc_code('R', '1', '0', ' ') /* [15:0] x:R 6:10 little endian */ > > -/* 12 bpp Red */ > +/* 12 bpp Red (or generic light-on-dark) */ > #define DRM_FORMAT_R12 fourcc_code('R', '1', '2', ' ') /* [15:0] x:R 4:12 little endian */ > > -/* 16 bpp Red */ > +/* 16 bpp Red (or generic light-on-dark) */ > #define DRM_FORMAT_R16 fourcc_code('R', '1', '6', ' ') /* [15:0] R little endian */ > > /* 16 bpp RG */ Hi Geert, this is a good idea. I just wonder whether light-on-dark is an accurate description. To me, light-on-dark means things like bright characters on a dark background, but that is a property of the image as a whole and not a property of the pixel format. What I think you are after here is that increasing channel value mean increasing brightness. How to word that concisely... Direct relationship to brightness (vs. inverse relationship to brightness)? This does not imply a linear relationship, and I'd also use "brightness" to denote that it is a qualitative factor relating to human observation. Thanks, pq
On 3/7/22 21:52, Geert Uytterhoeven wrote: > Traditionally, the first channel has been called the "red" channel, but > the fourcc values for single-channel "red" formats can also be used for > other light-on-dark displays, like grayscale. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- Yes, I learned that "Red" actually meant just a color channel that may not be red in one of the thread about fourcc formats. So I agree that would be good to have a comment about this. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index 457ed39cc48f08e1..f0187cf20e4619d2 100644 --- a/include/uapi/drm/drm_fourcc.h +++ b/include/uapi/drm/drm_fourcc.h @@ -104,16 +104,16 @@ extern "C" { #define DRM_FORMAT_C4 fourcc_code('C', '4', ' ', ' ') /* [7:0] C0:C1 4:4 two pixels/byte */ #define DRM_FORMAT_C8 fourcc_code('C', '8', ' ', ' ') /* [7:0] C 8 one pixel/byte */ -/* 8 bpp Red */ +/* 8 bpp Red (or generic light-on-dark) */ #define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') /* [7:0] R */ -/* 10 bpp Red */ +/* 10 bpp Red (or generic light-on-dark) */ #define DRM_FORMAT_R10 fourcc_code('R', '1', '0', ' ') /* [15:0] x:R 6:10 little endian */ -/* 12 bpp Red */ +/* 12 bpp Red (or generic light-on-dark) */ #define DRM_FORMAT_R12 fourcc_code('R', '1', '2', ' ') /* [15:0] x:R 4:12 little endian */ -/* 16 bpp Red */ +/* 16 bpp Red (or generic light-on-dark) */ #define DRM_FORMAT_R16 fourcc_code('R', '1', '6', ' ') /* [15:0] R little endian */ /* 16 bpp RG */
Traditionally, the first channel has been called the "red" channel, but the fourcc values for single-channel "red" formats can also be used for other light-on-dark displays, like grayscale. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- RFC, as I have no immediate need for these formats. v2: - New. --- include/uapi/drm/drm_fourcc.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)