| Message ID | 87bk4p4hkt.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | use for_each_endpoint_of_node() | expand |
Hi Morimoto-san, Thank you for the patch. On Tue, May 28, 2024 at 11:55:46PM +0000, Kuninori Morimoto wrote: > We already have for_each_endpoint_of_node(), don't use > of_graph_get_next_endpoint() directly. Replace it. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > drivers/media/platform/xilinx/xilinx-vipp.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c > index 996684a730383..38818b82a575e 100644 > --- a/drivers/media/platform/xilinx/xilinx-vipp.c > +++ b/drivers/media/platform/xilinx/xilinx-vipp.c > @@ -205,12 +205,7 @@ static int xvip_graph_build_dma(struct xvip_composite_device *xdev) I think ep doesn't have to be initialized to NULL anymore. Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > dev_dbg(xdev->dev, "creating links for DMA engines\n"); > > - while (1) { > - /* Get the next endpoint and parse its link. */ > - ep = of_graph_get_next_endpoint(node, ep); > - if (ep == NULL) > - break; > - > + for_each_endpoint_of_node(node, ep) { > dev_dbg(xdev->dev, "processing endpoint %pOF\n", ep); > > ret = v4l2_fwnode_parse_link(of_fwnode_handle(ep), &link);
diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c index 996684a730383..38818b82a575e 100644 --- a/drivers/media/platform/xilinx/xilinx-vipp.c +++ b/drivers/media/platform/xilinx/xilinx-vipp.c @@ -205,12 +205,7 @@ static int xvip_graph_build_dma(struct xvip_composite_device *xdev) dev_dbg(xdev->dev, "creating links for DMA engines\n"); - while (1) { - /* Get the next endpoint and parse its link. */ - ep = of_graph_get_next_endpoint(node, ep); - if (ep == NULL) - break; - + for_each_endpoint_of_node(node, ep) { dev_dbg(xdev->dev, "processing endpoint %pOF\n", ep); ret = v4l2_fwnode_parse_link(of_fwnode_handle(ep), &link);
We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- drivers/media/platform/xilinx/xilinx-vipp.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)