From patchwork Mon Jun 3 01:18:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 13683179 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11011009.outbound.protection.outlook.com [52.101.228.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 397184C90; Mon, 3 Jun 2024 01:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.9 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717377523; cv=fail; b=PVmnhfNHxB0IE5vKB63kcxiUWvaM7dmk2lpr11WYO+DVNDejvwzGfCMnEutzoSCDQWYM0Byy254qNZpSnmI4sOh0rTtUg1dRuowDee5fiuVw1PC1q4RGCRst6XzF7rTY9raujUnT7YNjxEF+kYLUIJikafKYOitn0BX5Fp07wUQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717377523; c=relaxed/simple; bh=Gj7gZCmCXBxP7NSFq5kl6WHPm2h/Iad/8G3zfc+eHok=; h=Message-ID:To:In-Reply-To:References:From:Subject:Content-Type: Date:MIME-Version; b=VCPfRsaLGRRUaMn6RHewwWXv+GsJc2mh65kX93GyZFPMM2wkDvnTf9wtoNP9e8CZbzherD1cyim4SyoJVD3oyaOKiIbzEKhpcNnTZy3GedgPqPiil/NjyZTOJLeyH8Hao05hCOKWxrWmfaJry0gRpCXedkbU5278fr3NzM02sOk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=RXMU90wH; arc=fail smtp.client-ip=52.101.228.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="RXMU90wH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XTspZxeOuGPsUsSuL9F/Hms/niyX+LpVz57mtKuvWSl84fzMRNRZsoLEa9xPBAXBZ8cfx9oUXpBfBp0NCoS5KITxF1qQSPVRCnJIJnqQ7a0Mo/lga4xGMhNiuonvfdwIyo1o2Gqp/c1HsSxvbLiwqf4T2CwMzUmeJ81nvhlmHN9L6Swd9XsKy1asmzXnHOSd0mRlm+Jm4eE76IC2maR+Rcv8doGK4bwbqPFrT7sKAikeYlKyK0LZGm+/PFc4ATknRzyQLYV0NQGiNs/gd5zJo+u7uDvtnQBLW9i4v8EYAhgxnuG6YoLu45G8l65T8hvsy/TSTLpFrB8gjsUHOXC4fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UyTYNVFuiPWsFlVH9oyG1GODHOUjUOsgwsvvhJOqvV0=; b=F8EI1Kb4imfyi1uiBazQzxiEjwp7VAok+eb1j23nIETVjr797ZaY2WIseoBi0uhc5wNUO4UBbKH6j1jgxwXNZ8qYeqnTPa1BKZLIL/nx3rqUE7a0mQkrw5qbpupehUeoIoi85pY4uJsDKXv0TQHBtVOunqSJGXuwQUo27pfHlNzN15uuY8Di35+IBLjDzGFKnFzhM+6rQ6SNAoZ2KC657I1ehitNP3iZKm7r/XrfvO6op+1GVm2h5GhtIn8jwTJWzXUWZsEQEzKDScvM9Z1MQJa1mZfHWZSR7AP8vpYWJfyt6tOrFOL81ywtfaayieCwwHHDLY99faeQnRYLmv0ziw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UyTYNVFuiPWsFlVH9oyG1GODHOUjUOsgwsvvhJOqvV0=; b=RXMU90wHOjJvsdLzMdBhq58Z+wk3b1Z68XvJ/o7K/jdo0+vrlCvh7ZL4cNOgrdj+1ZZ1InAjxGQ+XbwQORM1kfbjukh3cghU1GVfgWMtLdVwJgWmL+GT3iy8N+AqBaBxeU80eCwbt5Mvxg1poC9YpRNzPUW+vVxdWIZEA0HTibg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) by TYCPR01MB11318.jpnprd01.prod.outlook.com (2603:1096:400:3c4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.26; Mon, 3 Jun 2024 01:18:38 +0000 Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::c568:1028:2fd1:6e11]) by TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::c568:1028:2fd1:6e11%4]) with mapi id 15.20.7633.021; Mon, 3 Jun 2024 01:18:38 +0000 Message-ID: <87le3m4ydt.wl-kuninori.morimoto.gx@renesas.com> To: "Lad Prabhakar" , Alexander Shishkin , Alexandre Belloni , Claudiu Beznea , Daniel Vetter , David Airlie , Eugen Hristev , Greg Kroah-Hartman , Helge Deller , Laurent Pinchart , Maarten Lankhorst , Mauro Carvalho Chehab , Maxime Ripard , Michal Simek , Nicolas Ferre , Rob Herring , Suzuki K Poulose , Thomas Zimmermann , Tomi Valkeinen , coresight@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev In-Reply-To: <87v82q4yg0.wl-kuninori.morimoto.gx@renesas.com> References: <87v82q4yg0.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH v4 7/9] staging: media: atmel: use for_each_endpoint_of_node() Date: Mon, 3 Jun 2024 01:18:38 +0000 X-ClientProxiedBy: TYCPR01CA0015.jpnprd01.prod.outlook.com (2603:1096:405::27) To TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB10914:EE_|TYCPR01MB11318:EE_ X-MS-Office365-Filtering-Correlation-Id: b029d902-a901-4b89-8911-08dc836b1938 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|7416005|1800799015|376005|52116005|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: QMqdnuVxXD4iLc7USteKpSCGXtf/53XDgLt8urBIZ2ED93faWIDeXhQwVXxSM9sgoT0TrtPiChPlbKaom6v2Cj7J4d4cmZjO5a9/dNvcFDk4sOS4tCvkVolHnrkaRwaLpb35GoZMTdUYRMmWM5X5eXcNnr89Tq3vdqOabnh4SiKrd7WamGmYRvtBRmObc1ptom2AxtPwJnqXtQghbySI2YB0RITLn93TLVveNJH0AWRH9WmfOj4G2C7outIe8vVhgr1BpKrG+7D+2ewiG2qyTKg0QDFnWlj6+ExU57VvZiufaoS4pYClV6RQOjki9rmw52uXD2voii8qvYohbdW4raZ/tcmhYowohlhUO96oNLRw6nNjnVTCCz7Prn2VK1MdEvLuE4pVZlgd/Nee5Q1bGDReNVl4hD245j0HeYUumkDISkef0CAHWD7Z52g/8HaY96GotdG+yKwFdeCbCRciwh70XRd0w0HCZtrRuQz3ZEjJoAAfhfzyZQiFizAEXEqdFhCrGFuzJzYcY9NK3dUcmmZldda1yTo+O0nzSsm/rSrZN8Lk7tsrcEXr06hHWGvpm258P16GNOE8JExd4ePCYgTupl54oY0M+LW5B01V4B8txXhydesT2q0lujw8MCq3jF1CELandqWqhD7Wi+6iEqxgB9yAGfRMgzmITv3Ggu52zUa+DNpqgtd0+oMNiSbo90xo9tDHEne6h0ari0RsszBJ2f2aiEwAB/f8P3WrTWCpbZP79tQqAjFh6To7ztFJLqr58Sv/iIRVcW0fD9QqFpqgH06UA2DHYG+IClYggsakh76ArygfJbgEb03OYtTeX7vnTqTOaYcNJwTeMyJHIKBle3UUewQg/QfPvdt+KT4hQAdME3Cxf+g1cOWxm4QuxNFB/BYUxn8H+Y10O87T1pLog5ayvWW4BdrBC9q2E7WOtwfFCDRdpAAlkObYzabzH4XOS3/OvX7Uc4elAoAEG6z21s3spkjpWEJtFqtb+ldOWdZxsI8Amq9yPSOFTx211WZ/H8aL3ROl0Lc9MNv6vFvhlxsBiHErdebFzar3tbK8vgHgRb6qXGINhtjPKd0hIksR122y/qdlnnrV+yNixqg+la0gq6Zrua9h1wNdMVbGalyhH3FOQk+BPNy5utmW838a5oD3VpKfXN26YuUpJfT6msRaZA4rHbH6Esdm26kP6VWDWnE7wjeadqHTIZ2RlW0DSwrnkN18jvi5i77HGoYuddUBwL7aNUyGwnU2vK/4LpWEdkYVAe/QpQrCYq4HlmJ1TX1Yf+QF4EmSv4BYa4pSNQMY2BBpoSCaR76Z0hulWcQS6aj1JSa8uzTl4anCVuKuWrggeuqtAMAz9uGxX2kjsVwz1QXkYz8APwzDBks= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB10914.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(1800799015)(376005)(52116005)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: tKR6/Di2NXSr6ajpIVNyM34t36jmBDWFLZj6fE6JE1PntfLUBXBaWctCAJTd5/gkTIiEz2mfM7nBP/rfOXGvm6kbop68r184yOdJCnMwvj7fqLRg5xPRQKx45U1QKqheeRLObGCh/HCAkpIkACfCD+/Ya7YUy9XensjmlS+oVnSCOIxcohOaiJ8l+Ikdpe+K+Ef90oFCXW+ERxYpaId/m+CqN/srcIkpHo7+NO29q/pY5HXFYG/jNkkLE02mS+rKglBJXNkPeCRynFxlD97S0pHoSeDEOtFYJhgXD1/JzXl7EpoMQLxbiCiMQ70u9HYVF/4cHZYbrgcH0xPyvGuqyY8ZaxG+/9nkX8LuqZ3/g3XhdZXKMs03rgcCqnib8sYncpv2LkUmyZuhtntmD1XzQDX6XnjGIqf+mA47NyBmfziH72uUx7NJNpy2vV0iacIfH7ZAy0MLgjeQQsFORk7XKGhslmKgK/q9bkZswdCaOVBEz5nWb+A03DaBsyGA4+TtlipaZ4QaqnpD2MBGMMYgyXrStV7PXYVBDsahGJoB7CveECLdAU2a0zRczVxUlQNrgBcAigmDwxWWrmLS0L8g6/IK5RgAW94s5mQj/ja22UGng0K4v+9nkMMUGcpJoLJTbsL8A4TAF7h5j7r9aXDY547tyLc1EVVrR0DoNrU6l4niV286/JXLazowsCMmHC69vfZw7U2iEsuVeuC+tlt/bCcKM/AlYTLJ9zJB+iQm410qtqZ9iVFxdR3jV1s5UqyWvvZInt9E5ftELY0Bx8hMph27/iN8eXodN+l/p/ukjm4xsnHFCJE289IH/CFvUif+li8EW2up3lBI72rQeZgqjs7ArkPhcvmPpC8v+dycv7KfBLlqAjJmgCMsK58W5Ysrhm6n2+gW+7hK6Cizzw8i+/uOtUFEDaE17xPdEUmCtEhmNoB7chWoN89dIzcRjGwPJLpoYG/6RynN3N+La7hd9fAblBHs/xmF7qgJka+Qh6fLAA1qIkpfOFyy30e7f0PueVhkdjG1XeDiXGfqgGaYBS6M/Kej6dR25g9w8tGlXkdXnwjsLozYhwTAa5EZj9y7t1TTuL5WcS9WIX9z4iQrVvq6WxkQSchevXbrcrKrBKloOp+HGSiRfpz5bOpnuAp7KVQlwttg5n+10Xxt7OhyMKVSojvCNoAjSpYV/C1uj6YJ/cnlqiXAEsS/3/JkWrR3u5Gx/cPX+1DPmUAQlZtV4E7JowuwkGsze1UAq8xY4Yz6JdtQHyz+OsNhigygYuDNbcIK8t36EOxpk9g3BD+GuXRWnb2acTdRq4vJYntjXYA5uHTpCw1YR84iXtHJQC/J/7f5iwcDwbXbxkClz852de0THLtNRpnV369JOkO2FMkSsrg/F58R+9mOvE4BBZu4rQFezPw4amljTYolek6Nb+t2xxHp+LZHzaW+hTVcBenm4Ameh3C8SeTfuEeIRnhFR/e09dYN5k98MnNhiAJS4BtivZ/UZqHbAUEfFzpie9EYVfBkuoBxkY7WzIMs9u3XHhgSPTCUZ7+XexrNZBwMSc8tnrK7ze6LPtpAlLVGmtiIObydVQ3PT+8AnakGqExLldZuWAFow5Ynpb/oTx4YyejoRoTN1n6dqtvJ7yklET8= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: b029d902-a901-4b89-8911-08dc836b1938 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10914.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 01:18:38.8614 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 752jIk1TKBJKz0trrD/cayY4J6mYzG0Sy1vd4RaN40zT3HUIV33sSoMK3T5c2cbpJXO8m2ip4uvBpB/Ba4plQWdBQhmDHX1lUf9d/D1/m+Fd3wxkI5K1uSHMGj/ybPBx X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB11318 We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart --- .../staging/media/deprecated/atmel/atmel-sama5d2-isc.c | 10 +++------- .../staging/media/deprecated/atmel/atmel-sama7g5-isc.c | 10 +++------- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c index 31b2b48085c59..712f916f0935f 100644 --- a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c +++ b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c @@ -333,20 +333,16 @@ static const u32 isc_sama5d2_gamma_table[][GAMMA_ENTRIES] = { static int isc_parse_dt(struct device *dev, struct isc_device *isc) { struct device_node *np = dev->of_node; - struct device_node *epn = NULL; + struct device_node *epn; struct isc_subdev_entity *subdev_entity; unsigned int flags; - int ret; + int ret = -EINVAL; INIT_LIST_HEAD(&isc->subdev_entities); - while (1) { + for_each_endpoint_of_node(np, epn) { struct v4l2_fwnode_endpoint v4l2_epn = { .bus_type = 0 }; - epn = of_graph_get_next_endpoint(np, epn); - if (!epn) - return 0; - ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(epn), &v4l2_epn); if (ret) { diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c index 020034f631f57..9485167d5b7d7 100644 --- a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c +++ b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c @@ -316,23 +316,19 @@ static const u32 isc_sama7g5_gamma_table[][GAMMA_ENTRIES] = { static int xisc_parse_dt(struct device *dev, struct isc_device *isc) { struct device_node *np = dev->of_node; - struct device_node *epn = NULL; + struct device_node *epn; struct isc_subdev_entity *subdev_entity; unsigned int flags; - int ret; + int ret = -EINVAL; bool mipi_mode; INIT_LIST_HEAD(&isc->subdev_entities); mipi_mode = of_property_read_bool(np, "microchip,mipi-mode"); - while (1) { + for_each_endpoint_of_node(np, epn) { struct v4l2_fwnode_endpoint v4l2_epn = { .bus_type = 0 }; - epn = of_graph_get_next_endpoint(np, epn); - if (!epn) - return 0; - ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(epn), &v4l2_epn); if (ret) {