diff mbox

[v2] fbdev: sh_mobile_lcdc: fixup B side hsync adjust settings

Message ID 87txoqmo3p.wl%kuninori.morimoto.gx@renesas.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kuninori Morimoto March 5, 2013, 5:07 a.m. UTC 
The lcdc B side horizon output is shifted
if sh_mobile_lcdc_pan() was called.
This patch fixup this issue.
It is tested on R8A7740 Armadillo800eva HDMI output.
Special thanks to Fukushima-san, and Sano-san

Reported-by: Osamu Fukushima <osamu.fukushima.wr@renesas.com>
Signed-off-by: Hideyuki Sano <hideyuki.sano.dn@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2

 - git log has tested SoC/board

 drivers/video/sh_mobile_lcdcfb.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart March 5, 2013, 3:45 p.m. UTC | #1 
Hi Morimoto-san,

Thanks for the patch.

On Monday 04 March 2013 21:07:10 Kuninori Morimoto wrote:
> The lcdc B side horizon output is shifted
> if sh_mobile_lcdc_pan() was called.
> This patch fixup this issue.
> It is tested on R8A7740 Armadillo800eva HDMI output.
> Special thanks to Fukushima-san, and Sano-san
> 
> Reported-by: Osamu Fukushima <osamu.fukushima.wr@renesas.com>
> Signed-off-by: Hideyuki Sano <hideyuki.sano.dn@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> v1 -> v2
> 
>  - git log has tested SoC/board
> 
>  drivers/video/sh_mobile_lcdcfb.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/sh_mobile_lcdcfb.c
> b/drivers/video/sh_mobile_lcdcfb.c index 63203ac..0264704 100644
> --- a/drivers/video/sh_mobile_lcdcfb.c
> +++ b/drivers/video/sh_mobile_lcdcfb.c
> @@ -858,6 +858,7 @@ static void sh_mobile_lcdc_geometry(struct
> sh_mobile_lcdc_chan *ch) tmp = ((mode->xres & 7) << 24) | ((display_h_total
> & 7) << 16)
> 
>  	    | ((mode->hsync_len & 7) << 8) | (hsync_pos & 7);
> 
>  	lcdc_write_chan(ch, LDHAJR, tmp);
> +	lcdc_write_chan_mirror(ch, LDHAJR, tmp);
>  }
> 
>  static void sh_mobile_lcdc_overlay_setup(struct sh_mobile_lcdc_overlay
> *ovl)
Simon Horman March 19, 2013, 4:19 a.m. UTC | #2 
On Tue, Mar 05, 2013 at 04:45:46PM +0100, Laurent Pinchart wrote:
> Hi Morimoto-san,
> 
> Thanks for the patch.
> 
> On Monday 04 March 2013 21:07:10 Kuninori Morimoto wrote:
> > The lcdc B side horizon output is shifted
> > if sh_mobile_lcdc_pan() was called.
> > This patch fixup this issue.
> > It is tested on R8A7740 Armadillo800eva HDMI output.
> > Special thanks to Fukushima-san, and Sano-san
> > 
> > Reported-by: Osamu Fukushima <osamu.fukushima.wr@renesas.com>
> > Signed-off-by: Hideyuki Sano <hideyuki.sano.dn@renesas.com>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Laurent, can you handle getting this merged?
If not, please let me know who to prod.

> 
> > ---
> > v1 -> v2
> > 
> >  - git log has tested SoC/board
> > 
> >  drivers/video/sh_mobile_lcdcfb.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/video/sh_mobile_lcdcfb.c
> > b/drivers/video/sh_mobile_lcdcfb.c index 63203ac..0264704 100644
> > --- a/drivers/video/sh_mobile_lcdcfb.c
> > +++ b/drivers/video/sh_mobile_lcdcfb.c
> > @@ -858,6 +858,7 @@ static void sh_mobile_lcdc_geometry(struct
> > sh_mobile_lcdc_chan *ch) tmp = ((mode->xres & 7) << 24) | ((display_h_total
> > & 7) << 16)
> > 
> >  	    | ((mode->hsync_len & 7) << 8) | (hsync_pos & 7);
> > 
> >  	lcdc_write_chan(ch, LDHAJR, tmp);
> > +	lcdc_write_chan_mirror(ch, LDHAJR, tmp);
> >  }
> > 
> >  static void sh_mobile_lcdc_overlay_setup(struct sh_mobile_lcdc_overlay
> > *ovl)
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Laurent Pinchart March 19, 2013, 12:38 p.m. UTC | #3 
Hi Simon,

On Tuesday 19 March 2013 13:19:52 Simon Horman wrote:
> On Tue, Mar 05, 2013 at 04:45:46PM +0100, Laurent Pinchart wrote:
> > On Monday 04 March 2013 21:07:10 Kuninori Morimoto wrote:
> > > The lcdc B side horizon output is shifted
> > > if sh_mobile_lcdc_pan() was called.
> > > This patch fixup this issue.
> > > It is tested on R8A7740 Armadillo800eva HDMI output.
> > > Special thanks to Fukushima-san, and Sano-san
> > > 
> > > Reported-by: Osamu Fukushima <osamu.fukushima.wr@renesas.com>
> > > Signed-off-by: Hideyuki Sano <hideyuki.sano.dn@renesas.com>
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Laurent, can you handle getting this merged?
> If not, please let me know who to prod.

We have no fbdev maintainer anymore. Can this be pushed through your tree ?
Kuninori Morimoto March 25, 2013, 7:33 a.m. UTC | #4 
Hi Laurent, Simon,

> > > On Monday 04 March 2013 21:07:10 Kuninori Morimoto wrote:
> > > > The lcdc B side horizon output is shifted
> > > > if sh_mobile_lcdc_pan() was called.
> > > > This patch fixup this issue.
> > > > It is tested on R8A7740 Armadillo800eva HDMI output.
> > > > Special thanks to Fukushima-san, and Sano-san
> > > > 
> > > > Reported-by: Osamu Fukushima <osamu.fukushima.wr@renesas.com>
> > > > Signed-off-by: Hideyuki Sano <hideyuki.sano.dn@renesas.com>
> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > 
> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > Laurent, can you handle getting this merged?
> > If not, please let me know who to prod.
> 
> We have no fbdev maintainer anymore. Can this be pushed through your tree ?

Could you please teach me current status of this patch ?

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman March 26, 2013, 1:19 p.m. UTC | #5 
On Mon, Mar 25, 2013 at 12:33:52AM -0700, Kuninori Morimoto wrote:
> 
> Hi Laurent, Simon,
> 
> > > > On Monday 04 March 2013 21:07:10 Kuninori Morimoto wrote:
> > > > > The lcdc B side horizon output is shifted
> > > > > if sh_mobile_lcdc_pan() was called.
> > > > > This patch fixup this issue.
> > > > > It is tested on R8A7740 Armadillo800eva HDMI output.
> > > > > Special thanks to Fukushima-san, and Sano-san
> > > > > 
> > > > > Reported-by: Osamu Fukushima <osamu.fukushima.wr@renesas.com>
> > > > > Signed-off-by: Hideyuki Sano <hideyuki.sano.dn@renesas.com>
> > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > 
> > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > 
> > > Laurent, can you handle getting this merged?
> > > If not, please let me know who to prod.
> > 
> > We have no fbdev maintainer anymore. Can this be pushed through your tree ?
> 
> Could you please teach me current status of this patch ?

Sorry, I have been a bit slow and haven't applied it yet.
I plan to do so shortly.
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto March 26, 2013, 11:56 p.m. UTC | #6 
Hi Simon

> > > > > On Monday 04 March 2013 21:07:10 Kuninori Morimoto wrote:
> > > > > > The lcdc B side horizon output is shifted
> > > > > > if sh_mobile_lcdc_pan() was called.
> > > > > > This patch fixup this issue.
> > > > > > It is tested on R8A7740 Armadillo800eva HDMI output.
> > > > > > Special thanks to Fukushima-san, and Sano-san
> > > > > > 
> > > > > > Reported-by: Osamu Fukushima <osamu.fukushima.wr@renesas.com>
> > > > > > Signed-off-by: Hideyuki Sano <hideyuki.sano.dn@renesas.com>
> > > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > > 
> > > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > > 
> > > > Laurent, can you handle getting this merged?
> > > > If not, please let me know who to prod.
> > > 
> > > We have no fbdev maintainer anymore. Can this be pushed through your tree ?
> > 
> > Could you please teach me current status of this patch ?
> 
> Sorry, I have been a bit slow and haven't applied it yet.
> I plan to do so shortly.

Thank you for your help!


Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman March 27, 2013, 6:03 a.m. UTC | #7 
On Tue, Mar 26, 2013 at 04:56:09PM -0700, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > > > > On Monday 04 March 2013 21:07:10 Kuninori Morimoto wrote:
> > > > > > > The lcdc B side horizon output is shifted
> > > > > > > if sh_mobile_lcdc_pan() was called.
> > > > > > > This patch fixup this issue.
> > > > > > > It is tested on R8A7740 Armadillo800eva HDMI output.
> > > > > > > Special thanks to Fukushima-san, and Sano-san
> > > > > > > 
> > > > > > > Reported-by: Osamu Fukushima <osamu.fukushima.wr@renesas.com>
> > > > > > > Signed-off-by: Hideyuki Sano <hideyuki.sano.dn@renesas.com>
> > > > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > > > 
> > > > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > > > 
> > > > > Laurent, can you handle getting this merged?
> > > > > If not, please let me know who to prod.
> > > > 
> > > > We have no fbdev maintainer anymore. Can this be pushed through your tree ?
> > > 
> > > Could you please teach me current status of this patch ?
> > 
> > Sorry, I have been a bit slow and haven't applied it yet.
> > I plan to do so shortly.
> 
> Thank you for your help!

Can I confirm if this is for v3.9 or v3.10.
If it is for v3.9 perhaps it is also suitable for -stable?
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto March 27, 2013, 6:08 a.m. UTC | #8 
Hi Simon

> > > Sorry, I have been a bit slow and haven't applied it yet.
> > > I plan to do so shortly.
> > 
> > Thank you for your help!
> 
> Can I confirm if this is for v3.9 or v3.10.
> If it is for v3.9 perhaps it is also suitable for -stable?

Yes, it needs in v3.9.
I'm not sure detail of -stable branch,
but it is very nice if it have this patch

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c
index 63203ac..0264704 100644
--- a/drivers/video/sh_mobile_lcdcfb.c
+++ b/drivers/video/sh_mobile_lcdcfb.c
@@ -858,6 +858,7 @@  static void sh_mobile_lcdc_geometry(struct sh_mobile_lcdc_chan *ch)
 	tmp = ((mode->xres & 7) << 24) | ((display_h_total & 7) << 16)
 	    | ((mode->hsync_len & 7) << 8) | (hsync_pos & 7);
 	lcdc_write_chan(ch, LDHAJR, tmp);
+	lcdc_write_chan_mirror(ch, LDHAJR, tmp);
 }
 
 static void sh_mobile_lcdc_overlay_setup(struct sh_mobile_lcdc_overlay *ovl)