From patchwork Wed Apr 24 11:42:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 2483951 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 5FB9A3FD85 for ; Wed, 24 Apr 2013 11:47:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758471Ab3DXLrP (ORCPT ); Wed, 24 Apr 2013 07:47:15 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:40941 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758462Ab3DXLrM (ORCPT ); Wed, 24 Apr 2013 07:47:12 -0400 Received: by mail-pa0-f45.google.com with SMTP id lf10so1138204pab.32 for ; Wed, 24 Apr 2013 04:47:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:in-reply-to:references:x-gm-message-state; bh=ED8YhT/Bk8C4SRsx6B1O5UpXfJb/W2K2J/QS2fCdIXk=; b=C86smC9VGP8XOnXzoWwCBYFpxaIR4XQfurvn99PU3+/F2O3dq1fhGNsnjdoQx7WCM5 PCDb/+l4NekMW+2+rI5dl0NgBM2izjsI7X8Ztpkh60dXhFGbd7ASxshSy0rZoV5sWbaG w/wfKVM2BpwjioJ9uCQek29l8aZZTjxz//ZDn8k4PdS3uUS5UO4pTVRq8DXBfmahiQqV v17tudskJbQqySOz6MLqDikx2v0IkPty5pqbT6ZOxJfqkFeH9tueZGK2iPIqwIhDDhtR GC1mzJe2lHqMHuYxbNGCYhPjKPQ28MJqCiYIO6wdhuJmEpzxHvoNPcLN2xHeE0kUG00Q m1WA== X-Received: by 10.68.226.106 with SMTP id rr10mr46520083pbc.127.1366804031520; Wed, 24 Apr 2013 04:47:11 -0700 (PDT) Received: from localhost ([122.172.242.146]) by mx.google.com with ESMTPSA id do4sm2788442pbc.8.2013.04.24.04.47.04 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 24 Apr 2013 04:47:10 -0700 (PDT) From: Viresh Kumar To: tj@kernel.org Cc: davem@davemloft.net, airlied@redhat.com, axboe@kernel.dk, tglx@linutronix.de, peterz@infradead.org, mingo@redhat.com, rostedt@goodmis.org, linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, arvind.chauhan@arm.com, linaro-kernel@lists.linaro.org, patches@linaro.org, Viresh Kumar , linux-fbdev@vger.kernel.org Subject: [PATCH V5 5/5] fbcon: queue work on power efficient wq Date: Wed, 24 Apr 2013 17:12:57 +0530 Message-Id: <89924f001e3ddd66ab41a16500569a976ea846fd.1366803121.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 1.7.12.rc2.18.g61b472e In-Reply-To: References: In-Reply-To: References: X-Gm-Message-State: ALoCoQkTPkizstPkx4txB+d7Si/JFoVtDvkqkyX5IMt4SK2IwNoaulOMJyzwdTAt7gJK94SeTv3i Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org fbcon uses workqueues and it has no real dependency of scheduling these on the cpu which scheduled them. On a idle system, it is observed that and idle cpu wakes up many times just to service this work. It would be better if we can schedule it on a cpu which the scheduler believes to be the most appropriate one. This patch replaces system_wq with system_power_efficient_wq. Cc: Dave Airlie Cc: linux-fbdev@vger.kernel.org Signed-off-by: Viresh Kumar --- drivers/video/console/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 3cd6759..0cae83d 100644 --- a/drivers/video/console/fbcon.c +++ b/drivers/video/console/fbcon.c @@ -404,7 +404,7 @@ static void cursor_timer_handler(unsigned long dev_addr) struct fb_info *info = (struct fb_info *) dev_addr; struct fbcon_ops *ops = info->fbcon_par; - schedule_work(&info->queue); + queue_work(system_power_efficient_wq, &info->queue); mod_timer(&ops->cursor_timer, jiffies + HZ/5); }