From patchwork Mon Jun 3 20:54:19 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 2655031 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 647FE40077 for ; Mon, 3 Jun 2013 20:54:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757435Ab3FCUyV (ORCPT ); Mon, 3 Jun 2013 16:54:21 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:41201 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756753Ab3FCUyU (ORCPT ); Mon, 3 Jun 2013 16:54:20 -0400 Received: by mail-pd0-f173.google.com with SMTP id v10so1193684pde.18 for ; Mon, 03 Jun 2013 13:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=cJ2EH9SmT5sYda+vDlzNEMhFmTZgLbvncswpGJ4R6r0=; b=H4OwJWeqBLD69b9oIb/mWlQ60w1KtnoKxb+4C9mKag2LaFitYkRHIpcE9kfnziF3Kw NuDCLa6Lp5ea4E0Lo3PQaL2miIgkBCHzp+j2cdvt/fYDzV4M8t+Vrry+ScPIFCgNcxoG s7SFqVNsFFNL+Jkowt5XyC341qlQoeKCOsjx8bAoSLVkbDLMqvGOZ6KE01My2Kbh2t2Z S6oyK2Y847o37CkOmVtps/ZLrRk03WDYizXIvH0GfVFafcQzukvIDRCO09SScyT5tfsI 5wab2mG35Tr5ncLJpgz9vFgzayo+lyGAHGhAFo4FNScORO4hOmt5ELK+wkkQRyRBkE8S mniA== MIME-Version: 1.0 X-Received: by 10.66.162.38 with SMTP id xx6mr26423457pab.69.1370292859983; Mon, 03 Jun 2013 13:54:19 -0700 (PDT) Received: by 10.70.3.34 with HTTP; Mon, 3 Jun 2013 13:54:19 -0700 (PDT) In-Reply-To: <51ACFDF2.4040600@infradead.org> References: <20130603163717.a6f78476e57d92fadd6f6a23@canb.auug.org.au> <51ACFDF2.4040600@infradead.org> Date: Mon, 3 Jun 2013 22:54:19 +0200 X-Google-Sender-Auth: axMXci_Syh_fmhrpaYEgjXweVvE Message-ID: Subject: Re: linux-next: Tree for Jun 3 (fonts.c & vivi) From: Geert Uytterhoeven To: Randy Dunlap Cc: Stephen Rothwell , Linux-Next , "linux-kernel@vger.kernel.org" , linux-media , Linux Fbdev development list Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Mon, Jun 3, 2013 at 10:34 PM, Randy Dunlap wrote: > On 06/02/13 23:37, Stephen Rothwell wrote: >> Changes since 20130531: > on x86_64: > > warning: (VIDEO_VIVI && USB_SISUSBVGA && SOLO6X10) selects FONT_SUPPORT which has unmet direct dependencies (HAS_IOMEM && VT) > warning: (VIDEO_VIVI && FB_VGA16 && FB_S3 && FB_VT8623 && FB_ARK && USB_SISUSBVGA_CON && SOLO6X10) selects FONT_8x16 which has unmet direct dependencies (HAS_IOMEM && VT && FONT_SUPPORT) I knew about thet warning. But I thought it was harmless, as none of the font code really depends on console support... > drivers/built-in.o: In function `vivi_init': > vivi.c:(.init.text+0x1a3da): undefined reference to `find_font' > > when CONFIG_VT is not enabled. ... but I missed that drivers/video/console is not used if CONFIG_VT=y. Sorry for that. > Just make CONFIG_VIDEO_VIVI depend on VT ? Does this (whitespace-damaged copy-and-paste) help? It shouldn't make a difference if nothing inside drivers/video/console is enabled, as all objects in drivers/video/console/Makefile are conditional. BTW, my plan was to move the font code to lib/font, but I haven't done that yet. Gr{oetje,eeting}s, Geert Acked-by: Randy Dunlap --- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/video/Makefile +++ b/drivers/video/Makefile @@ -12,7 +12,7 @@ fb-y := fbmem.o fbmon.o fbcmap.o modedb.o fbcvt.o fb-objs := $(fb-y) -obj-$(CONFIG_VT) += console/ +obj-y += console/ obj-$(CONFIG_LOGO) += logo/ obj-y += backlight/