From patchwork Fri Jan 23 15:06:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 5694551 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D2B639F2ED for ; Fri, 23 Jan 2015 15:07:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F178A20306 for ; Fri, 23 Jan 2015 15:07:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2D6B20303 for ; Fri, 23 Jan 2015 15:07:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751453AbbAWPHA (ORCPT ); Fri, 23 Jan 2015 10:07:00 -0500 Received: from mail-lb0-f179.google.com ([209.85.217.179]:49903 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbbAWPG7 (ORCPT ); Fri, 23 Jan 2015 10:06:59 -0500 Received: by mail-lb0-f179.google.com with SMTP id 10so6278862lbg.10; Fri, 23 Jan 2015 07:06:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Txbmtk/JUToPXtg0179nBfzCdtXcTnjSXJ5VwdSO6y4=; b=sZ2CPdTAhP77hXx4fb0bnH1BWtkhvuy4Y6BebVE/ydGle+v1DfoegJ6AiL7eI+Ss1o KDjuXqiGHbKGLUJNmtLQ5sBmLRMSVTo4+V22FdadZgNf7infBlxBgFfpzV05rBBbgZHR c0cn+0DyAuCrUZFyR+Mc2gFKcrWW5WENhWTUySYX51+jFVkQ1W6vGHZxiJnmOZC0Pzo9 eMLPpSz7aVtH7ORywcyhVqbFH1tJLQmPVuOkvgP8EERG1Vv9Jj8EFSwOxuqSTr2rMrZ2 1P+O/BYHZIR8iIkRbOCW7a3wXnVXvvr89r+uxBKPYxkbbi7DYDX005sVglvY2VAKmz5W 2qGQ== MIME-Version: 1.0 X-Received: by 10.152.21.134 with SMTP id v6mr7810193lae.13.1422025616329; Fri, 23 Jan 2015 07:06:56 -0800 (PST) Received: by 10.152.179.137 with HTTP; Fri, 23 Jan 2015 07:06:56 -0800 (PST) In-Reply-To: <20150123025643.GA11412@victor> References: <1418954426-21909-1-git-send-email-steve_longerbeam@mentor.com> <1420655248.3191.73.camel@pengutronix.de> <20150123025643.GA11412@victor> Date: Fri, 23 Jan 2015 13:06:56 -0200 Message-ID: Subject: Re: [PATCH v2 0/7] imx-drm: ipuv3-crtc: Implement mode_fixup From: Fabio Estevam To: Liu Ying Cc: Philipp Zabel , Fabio Estevam , "linux-fbdev@vger.kernel.org" , Steve Longerbeam , linux-kernel , DRI mailing list , Denis Carikli , Tomi Valkeinen , Steve Longerbeam , Russell King , Jean-Christophe Plagniol-Villard Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Jan 23, 2015 at 12:56 AM, Liu Ying wrote: > Hi, > > It looks that the below commit makes my Hannstar XGA LVDS panel stop working > on the i.MX6DL SabreSD board. Any idea? Yes, with eb10d6355532def3a ("mx-drm: encoder prepare/mode_set must use adjusted mode") applied the DI clock is 0: --- a/drivers/gpu/drm/imx/imx-ldb.c +++ b/drivers/gpu/drm/imx/imx-ldb.c @@ -169,6 +169,8 @@ static void imx_ldb_encoder_prepare(struct drm_encoder *encoder) unsigned long di_clk = mode->clock * 1000; int mux = imx_drm_encoder_get_mux_id(imx_ldb_ch->child, encoder); + pr_err("********* DI clock is %ld\n", di_clk); + if (ldb->ldb_ctrl & LDB_SPLIT_MODE_EN) { With eb10d6355532def3a applied: [ 1.493745] ********* DI clock is 0 With eb10d6355532def3a reverted: [ 1.493639] ********* DI clock is 65000000 Should we just go back to the previous usage? --- a/drivers/gpu/drm/imx/imx-ldb.c +++ b/drivers/gpu/drm/imx/imx-ldb.c @@ -163,12 +163,14 @@ static void imx_ldb_encoder_prepare(struct drm_encoder *encoder) { struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder); struct imx_ldb *ldb = imx_ldb_ch->ldb; - struct drm_display_mode *mode = &encoder->crtc->hwmode; + struct drm_display_mode *mode = &encoder->crtc->mode; u32 pixel_fmt; -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html