From patchwork Sat Oct 12 06:25:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 3030871 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6F7A59F2B7 for ; Sat, 12 Oct 2013 06:25:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 73DBB20394 for ; Sat, 12 Oct 2013 06:25:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36DD120387 for ; Sat, 12 Oct 2013 06:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163Ab3JLGZY (ORCPT ); Sat, 12 Oct 2013 02:25:24 -0400 Received: from mail-bk0-f47.google.com ([209.85.214.47]:58725 "EHLO mail-bk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752110Ab3JLGZY (ORCPT ); Sat, 12 Oct 2013 02:25:24 -0400 Received: by mail-bk0-f47.google.com with SMTP id mx12so1886520bkb.34 for ; Fri, 11 Oct 2013 23:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=8ejBxB4ddGOwB5pvoITxgD03oKfBulXUN2JmBmx7NS0=; b=AURA0ou7haNaydpFPMZcPaWGADqhldAzHc/VfyVhI13nKw54QNrcMBvYjGGAtD8UN6 oS6C1Oc6ESie9Pm5TXtoPHbIoTkGKoycxRnrNqHl+7NBb9LwstddNbgaowe0SaWoIRbW KAjhLDzmU36ta3hUhVoUsDDgPH/7TJBGSKFKuExsjne0wGSltwPLvt7JJ7ZucbVhuC4a Iw9EQ8hm36BLfZdSe8mSI1USgGyCS8r9dai8vij4QMzg93OPlzt6j03khgbmjk45AHyY 01JQBvtIukGrR6OQiNK1mp8JS+9i1tOrPB6uZhKTPMN6j3rhOZIjMgGveODJVy80rRpo ZC5g== MIME-Version: 1.0 X-Received: by 10.204.233.129 with SMTP id jy1mr165774bkb.27.1381559123141; Fri, 11 Oct 2013 23:25:23 -0700 (PDT) Received: by 10.205.19.10 with HTTP; Fri, 11 Oct 2013 23:25:23 -0700 (PDT) Date: Sat, 12 Oct 2013 14:25:23 +0800 Message-ID: Subject: [PATCH] fbdev: fix error return code in metronomefb_probe() From: Wei Yongjun To: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com Cc: yongjun_wei@trendmicro.com.cn, linux-fbdev@vger.kernel.org Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Acked-by: Jean-Christophe PLAGNIOL-VILLARD --- drivers/video/metronomefb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c index f30150d..0b36160 100644 --- a/drivers/video/metronomefb.c +++ b/drivers/video/metronomefb.c @@ -690,7 +690,8 @@ static int metronomefb_probe(struct platform_device *dev) goto err_csum_table; } - if (board->setup_irq(info)) + retval = board->setup_irq(info); + if (retval) goto err_csum_table; retval = metronome_init_regs(par);