From patchwork Fri Sep 27 09:50:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2953511 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E2EAABFF0B for ; Fri, 27 Sep 2013 09:50:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0894F202C1 for ; Fri, 27 Sep 2013 09:50:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC4F320278 for ; Fri, 27 Sep 2013 09:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753148Ab3I0Jut (ORCPT ); Fri, 27 Sep 2013 05:50:49 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:65448 "EHLO mail-bk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752941Ab3I0Jut (ORCPT ); Fri, 27 Sep 2013 05:50:49 -0400 Received: by mail-bk0-f44.google.com with SMTP id mz10so874520bkb.31 for ; Fri, 27 Sep 2013 02:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=Cn95rEsC1SxdGAbaecvRdpDA0xSI4R8RzTGgqxoJxNE=; b=alvqADFAIwHNTl2j4Q2AqjBy7Rj4sTBdkwGMPAEQ/fz7oAAD81alHMXyFlCO4wWsEU +Dp5pZJo2HmkxUOxAAEvhw1o30hJJXfq4BCvRuuPflQYAR8sCjIxch68pt7HT1b+liwm 488YxgLKNGQEUPVzyBzfnl42jrGbNnYN4yCqGmcmsHXNxODYgyccw0X8oO+U6RqwiC9I tw5D53+YY5krKN8rceMLIXIZuZx9A4waUCin686f/X/7gNbN9umDvc40gCYZZgZldOas E14jz/Jv20USx0L+9pNIpu34VI0aSeY2k1GvHSG45166RYp7VVoGgJmeVnqRtCly0L1d mEMA== MIME-Version: 1.0 X-Received: by 10.204.68.142 with SMTP id v14mr4996183bki.18.1380275447634; Fri, 27 Sep 2013 02:50:47 -0700 (PDT) Received: by 10.205.13.74 with HTTP; Fri, 27 Sep 2013 02:50:47 -0700 (PDT) Date: Fri, 27 Sep 2013 17:50:47 +0800 Message-ID: Subject: [PATCH -next] backlight: lm3630: add missing destroy_workqueue() on error in lm3630a_intr_config() From: Wei Yongjun To: rpurdie@rpsys.net, jg1.han@samsung.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com Cc: yongjun_wei@trendmicro.com.cn, linux-fbdev@vger.kernel.org Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Add the missing destroy_workqueue() before return from lm3630a_intr_config() in the error handling case. Signed-off-by: Wei Yongjun Acked-by: Jingoo Han --- drivers/video/backlight/lm3630a_bl.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index c63f918..0e5d8d3 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -154,6 +154,7 @@ static int lm3630a_intr_config(struct lm3630a_chip *pchip) (pchip->irq, NULL, lm3630a_isr_func, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "lm3630a_irq", pchip)) { dev_err(pchip->dev, "request threaded irq fail\n"); + destroy_workqueue(pchip->irqthread); return -ENOMEM; } return rval;