From patchwork Thu Jun 10 19:34:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russ Weight X-Patchwork-Id: 12313823 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02668C48BD1 for ; Thu, 10 Jun 2021 19:34:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6A6761419 for ; Thu, 10 Jun 2021 19:34:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230381AbhFJTga (ORCPT ); Thu, 10 Jun 2021 15:36:30 -0400 Received: from mga17.intel.com ([192.55.52.151]:36545 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbhFJTga (ORCPT ); Thu, 10 Jun 2021 15:36:30 -0400 IronPort-SDR: 2atyPgF+Cwz/f/Rr5dwZFppaUzz2ib/CwiyeSSEoripUn4k1bjhfWPDGr1kV4fhZBrSWfmQh9D v1vydFU/TEDg== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="185756067" X-IronPort-AV: E=Sophos;i="5.83,264,1616482800"; d="scan'208";a="185756067" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 12:34:27 -0700 IronPort-SDR: sCR7hKqyO7lZ/lolcl2lJ5Y1kxyUNY/daTr3wJkpDjL0MYC+o5C7g/X/M0wWHTmeLKYKsyC3hT GswdPMS23oFQ== X-IronPort-AV: E=Sophos;i="5.83,264,1616482800"; d="scan'208";a="477458069" Received: from rhweight-mobl2.amr.corp.intel.com (HELO rhweight-mobl2.ra.intel.com) ([10.212.184.121]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 12:34:25 -0700 From: Russ Weight To: mdf@kernel.org, linux-fpga@vger.kernel.org Cc: trix@redhat.com, lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com, matthew.gerlach@intel.com, richard.gong@intel.com, Russ Weight Subject: [PATCH v3 0/8] fpga: Populate dev_release functions Date: Thu, 10 Jun 2021 12:34:14 -0700 Message-Id: <20210610193422.286835-1-russell.h.weight@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org The FPGA framework has a convention of using managed resource functions to allow parent drivers to manage the data structures allocated by the class drivers. They use an empty *_dev_release() function to satisfy the class driver. This is inconsistent with linux driver model. These changes populate the class dev_release callback functions while maintaining the current API. Additional changes are made to maintain consistency with the driver model. For more context on these changes, refer to this email thread: https://marc.info/?l=linux-fpga&m=162127412218557&w=2 Changelog v2 -> v3: - Added Reviewed-by tags - Moved a "dev" to "parent" rename in the comment header for devm_fpga_region_create() from patch 8 to patch 5. Changelog v1 -> v2: - Moved the renaming of "dev" to "parent" into a separate patch each for fpga-mgr, fpga-bridge, fpga-region. - Restored the call to fpga_mgr_free() in devm_*_mgr_release() instead of changing it to put_device(). - Replaced patch "fpga: altera-pr-ip: Remove function alt_pr_unregister" with "fpga: altera-pr-ip: Remove function alt_pr_unregister". This patch removes the alt_pr_unregister() function altogether, instead of just removing portions of it. Russ Weight (8): fpga: altera-pr-ip: Remove function alt_pr_unregister fpga: stratix10-soc: Add missing fpga_mgr_free() call fpga: mgr: Rename dev to parent for parent device fpga: bridge: Rename dev to parent for parent device fpga: region: Rename dev to parent for parent device fpga: mgr: Use standard dev_release for class driver fpga: bridge: Use standard dev_release for class driver fpga: region: Use standard dev_release for class driver drivers/fpga/altera-pr-ip-core.c | 10 ----- drivers/fpga/fpga-bridge.c | 46 ++++++++++----------- drivers/fpga/fpga-mgr.c | 55 ++++++++++++-------------- drivers/fpga/fpga-region.c | 44 ++++++++++----------- drivers/fpga/stratix10-soc.c | 1 + include/linux/fpga/altera-pr-ip-core.h | 1 - 6 files changed, 71 insertions(+), 86 deletions(-)