| Message ID | 0060e55f0b8d3a57e129d7eb096267cc96eae846.1581517026.git.michal.simek@xilinx.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | fpga: zynq: Remove clk_get error message for probe defer | expand |
On 12. 02. 20 15:17, Michal Simek wrote: > From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > In probe, the driver checks for devm_clk_get return and print error > message in the failing case. However for -EPROBE_DEFER this message is > confusing so avoid it. > > The similar change was done also by commit 28910cee898c > ("fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer") > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/fpga/zynq-fpga.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c > index ee7765049607..07fa8d9ec675 100644 > --- a/drivers/fpga/zynq-fpga.c > +++ b/drivers/fpga/zynq-fpga.c > @@ -583,7 +583,8 @@ static int zynq_fpga_probe(struct platform_device *pdev) > > priv->clk = devm_clk_get(dev, "ref_clk"); > if (IS_ERR(priv->clk)) { > - dev_err(dev, "input clock not found\n"); > + if (PTR_ERR(priv->clk) != -EPROBE_DEFER) > + dev_err(dev, "input clock not found\n"); > return PTR_ERR(priv->clk); > } > > Moritz: Any comment on this one? Thanks, Michal
On Wed, Feb 12, 2020 at 03:17:08PM +0100, Michal Simek wrote: > From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > In probe, the driver checks for devm_clk_get return and print error > message in the failing case. However for -EPROBE_DEFER this message is > confusing so avoid it. > > The similar change was done also by commit 28910cee898c > ("fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer") > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/fpga/zynq-fpga.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c > index ee7765049607..07fa8d9ec675 100644 > --- a/drivers/fpga/zynq-fpga.c > +++ b/drivers/fpga/zynq-fpga.c > @@ -583,7 +583,8 @@ static int zynq_fpga_probe(struct platform_device *pdev) > > priv->clk = devm_clk_get(dev, "ref_clk"); > if (IS_ERR(priv->clk)) { > - dev_err(dev, "input clock not found\n"); > + if (PTR_ERR(priv->clk) != -EPROBE_DEFER) > + dev_err(dev, "input clock not found\n"); > return PTR_ERR(priv->clk); > } > > -- > 2.25.0 > Applied to for-next. Thanks, Moritz
diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index ee7765049607..07fa8d9ec675 100644 --- a/drivers/fpga/zynq-fpga.c +++ b/drivers/fpga/zynq-fpga.c @@ -583,7 +583,8 @@ static int zynq_fpga_probe(struct platform_device *pdev) priv->clk = devm_clk_get(dev, "ref_clk"); if (IS_ERR(priv->clk)) { - dev_err(dev, "input clock not found\n"); + if (PTR_ERR(priv->clk) != -EPROBE_DEFER) + dev_err(dev, "input clock not found\n"); return PTR_ERR(priv->clk); }