| Message ID | 1600140473-12351-4-git-send-email-yilun.xu@intel.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | add DFL bus support to MODULE_DEVICE_TABLE() | expand |
On Tue, Sep 15, 2020 at 11:27:52AM +0800, Xu Yilun wrote: > The description of feature_id in struct dfl_device is not accurate. In > DFL specification the feature_id is the 12 bits field. The description > in struct dfl_device_id is more clear so we make them aligned. We also > made the similar fix for the type field. > > Signed-off-by: Xu Yilun <yilun.xu@intel.com> > --- > drivers/fpga/dfl.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h > index 3c69596..d5e050a 100644 > --- a/drivers/fpga/dfl.h > +++ b/drivers/fpga/dfl.h > @@ -531,8 +531,8 @@ enum dfl_id_type { > * > * @dev: generic device interface. > * @id: id of the dfl device. > - * @type: type of DFL FIU of the device. See enum dfl_id_type. > - * @feature_id: 16 bits feature identifier local to its DFL FIU type. > + * @type: contains 4 bits DFL FIU type of the device. See enum dfl_id_type. > + * @feature_id: contains 12 bits feature identifier local to its DFL FIU type. > * @mmio_res: mmio resource of this dfl device. > * @irqs: list of Linux IRQ numbers of this dfl device. > * @num_irqs: number of IRQs supported by this dfl device. > -- > 2.7.4 > Applied to for-next, Thanks
> On Tue, Sep 15, 2020 at 11:27:52AM +0800, Xu Yilun wrote: > > The description of feature_id in struct dfl_device is not accurate. In > > DFL specification the feature_id is the 12 bits field. The description > > in struct dfl_device_id is more clear so we make them aligned. We also > > made the similar fix for the type field. > > > > Signed-off-by: Xu Yilun <yilun.xu@intel.com> Acked-by: Wu Hao <hao.wu@intel.com> Thanks Hao > > --- > > drivers/fpga/dfl.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h > > index 3c69596..d5e050a 100644 > > --- a/drivers/fpga/dfl.h > > +++ b/drivers/fpga/dfl.h > > @@ -531,8 +531,8 @@ enum dfl_id_type { > > * > > * @dev: generic device interface. > > * @id: id of the dfl device. > > - * @type: type of DFL FIU of the device. See enum dfl_id_type. > > - * @feature_id: 16 bits feature identifier local to its DFL FIU type. > > + * @type: contains 4 bits DFL FIU type of the device. See enum dfl_id_type. > > + * @feature_id: contains 12 bits feature identifier local to its DFL FIU type. > > * @mmio_res: mmio resource of this dfl device. > > * @irqs: list of Linux IRQ numbers of this dfl device. > > * @num_irqs: number of IRQs supported by this dfl device. > > -- > > 2.7.4 > > > > Applied to for-next, > > Thanks
diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h index 3c69596..d5e050a 100644 --- a/drivers/fpga/dfl.h +++ b/drivers/fpga/dfl.h @@ -531,8 +531,8 @@ enum dfl_id_type { * * @dev: generic device interface. * @id: id of the dfl device. - * @type: type of DFL FIU of the device. See enum dfl_id_type. - * @feature_id: 16 bits feature identifier local to its DFL FIU type. + * @type: contains 4 bits DFL FIU type of the device. See enum dfl_id_type. + * @feature_id: contains 12 bits feature identifier local to its DFL FIU type. * @mmio_res: mmio resource of this dfl device. * @irqs: list of Linux IRQ numbers of this dfl device. * @num_irqs: number of IRQs supported by this dfl device.
The description of feature_id in struct dfl_device is not accurate. In DFL specification the feature_id is the 12 bits field. The description in struct dfl_device_id is more clear so we make them aligned. We also made the similar fix for the type field. Signed-off-by: Xu Yilun <yilun.xu@intel.com> --- drivers/fpga/dfl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)