| Message ID | 1612909233-13867-2-git-send-email-richard.gong@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Extend Intel service layer, FPGA manager and region | expand |
On 2/9/21 2:20 PM, richard.gong@linux.intel.com wrote: > From: Richard Gong <richard.gong@intel.com> > > Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which > aligns with the firmware settings. > > Fixes: 36847f9e3e56 ("firmware: stratix10-svc: correct reconfig flag and timeout values") > Signed-off-by: Richard Gong <richard.gong@intel.com> > --- > v5: new add, add the missing standalone patch > --- > include/linux/firmware/intel/stratix10-svc-client.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h > index a93d859..f843c6a 100644 > --- a/include/linux/firmware/intel/stratix10-svc-client.h > +++ b/include/linux/firmware/intel/stratix10-svc-client.h > @@ -56,7 +56,7 @@ > * COMMAND_RECONFIG_FLAG_PARTIAL: > * Set to FPGA configuration type (full or partial). > */ > -#define COMMAND_RECONFIG_FLAG_PARTIAL 1 > +#define COMMAND_RECONFIG_FLAG_PARTIAL 0 Is this the stand alone fix split from v3's patch 1 ? https://lore.kernel.org/linux-fpga/YBFW50LPP%2FyEbvEW@kroah.com/ Tom > > /** > * Timeout settings for service clients:
On 2/15/21 6:41 AM, Richard Gong wrote: > Hi Tom, > > On 2/13/21 9:44 AM, Tom Rix wrote: >> >> On 2/9/21 2:20 PM, richard.gong@linux.intel.com wrote: >>> From: Richard Gong <richard.gong@intel.com> >>> >>> Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which >>> aligns with the firmware settings. >>> >>> Fixes: 36847f9e3e56 ("firmware: stratix10-svc: correct reconfig flag and timeout values") >>> Signed-off-by: Richard Gong <richard.gong@intel.com> >>> --- >>> v5: new add, add the missing standalone patch >>> --- >>> include/linux/firmware/intel/stratix10-svc-client.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h >>> index a93d859..f843c6a 100644 >>> --- a/include/linux/firmware/intel/stratix10-svc-client.h >>> +++ b/include/linux/firmware/intel/stratix10-svc-client.h >>> @@ -56,7 +56,7 @@ >>> * COMMAND_RECONFIG_FLAG_PARTIAL: >>> * Set to FPGA configuration type (full or partial). >>> */ >>> -#define COMMAND_RECONFIG_FLAG_PARTIAL 1 >>> +#define COMMAND_RECONFIG_FLAG_PARTIAL 0 >> >> Is this the stand alone fix split from v3's patch 1 ? >> >> https://lore.kernel.org/linux-fpga/YBFW50LPP%2FyEbvEW@kroah.com/ >> Yes, it is a stand-alone patch. Thanks. Reviewed-by: Tom Rix <trix@redhat.com> > >> Tom >> >>> /** >>> * Timeout settings for service clients: >> > Regards, > Richard >
Hi Tom, On 2/13/21 9:44 AM, Tom Rix wrote: > > On 2/9/21 2:20 PM, richard.gong@linux.intel.com wrote: >> From: Richard Gong <richard.gong@intel.com> >> >> Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which >> aligns with the firmware settings. >> >> Fixes: 36847f9e3e56 ("firmware: stratix10-svc: correct reconfig flag and timeout values") >> Signed-off-by: Richard Gong <richard.gong@intel.com> >> --- >> v5: new add, add the missing standalone patch >> --- >> include/linux/firmware/intel/stratix10-svc-client.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h >> index a93d859..f843c6a 100644 >> --- a/include/linux/firmware/intel/stratix10-svc-client.h >> +++ b/include/linux/firmware/intel/stratix10-svc-client.h >> @@ -56,7 +56,7 @@ >> * COMMAND_RECONFIG_FLAG_PARTIAL: >> * Set to FPGA configuration type (full or partial). >> */ >> -#define COMMAND_RECONFIG_FLAG_PARTIAL 1 >> +#define COMMAND_RECONFIG_FLAG_PARTIAL 0 > > Is this the stand alone fix split from v3's patch 1 ? > > https://lore.kernel.org/linux-fpga/YBFW50LPP%2FyEbvEW@kroah.com/ >Yes, it is a stand-alone patch. > Tom > >> >> /** >> * Timeout settings for service clients: > Regards, Richard
On Mon, Feb 15, 2021 at 06:32:16AM -0800, Tom Rix wrote: > > On 2/15/21 6:41 AM, Richard Gong wrote: > > Hi Tom, > > > > On 2/13/21 9:44 AM, Tom Rix wrote: > >> > >> On 2/9/21 2:20 PM, richard.gong@linux.intel.com wrote: > >>> From: Richard Gong <richard.gong@intel.com> > >>> > >>> Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which > >>> aligns with the firmware settings. > >>> > >>> Fixes: 36847f9e3e56 ("firmware: stratix10-svc: correct reconfig flag and timeout values") > >>> Signed-off-by: Richard Gong <richard.gong@intel.com> > >>> --- > >>> v5: new add, add the missing standalone patch > >>> --- > >>> include/linux/firmware/intel/stratix10-svc-client.h | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h > >>> index a93d859..f843c6a 100644 > >>> --- a/include/linux/firmware/intel/stratix10-svc-client.h > >>> +++ b/include/linux/firmware/intel/stratix10-svc-client.h > >>> @@ -56,7 +56,7 @@ > >>> * COMMAND_RECONFIG_FLAG_PARTIAL: > >>> * Set to FPGA configuration type (full or partial). > >>> */ > >>> -#define COMMAND_RECONFIG_FLAG_PARTIAL 1 > >>> +#define COMMAND_RECONFIG_FLAG_PARTIAL 0 > >> > >> Is this the stand alone fix split from v3's patch 1 ? > >> > >> https://lore.kernel.org/linux-fpga/YBFW50LPP%2FyEbvEW@kroah.com/ > >> Yes, it is a stand-alone patch. > > Thanks. > > Reviewed-by: Tom Rix <trix@redhat.com> > > > > >> Tom > >> > >>> /** > >>> * Timeout settings for service clients: > >> > > Regards, > > Richard > > > Applied to fixes. Thanks, Moritz
diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h index a93d859..f843c6a 100644 --- a/include/linux/firmware/intel/stratix10-svc-client.h +++ b/include/linux/firmware/intel/stratix10-svc-client.h @@ -56,7 +56,7 @@ * COMMAND_RECONFIG_FLAG_PARTIAL: * Set to FPGA configuration type (full or partial). */ -#define COMMAND_RECONFIG_FLAG_PARTIAL 1 +#define COMMAND_RECONFIG_FLAG_PARTIAL 0 /** * Timeout settings for service clients: