| Message ID | 1628836842-82107-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fpga: machxo2-spi: Fix missing error code in machxo2_write_complete() | expand |
On Thu, Aug 12, 2021 at 11:41 PM Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > > The error code is missing in this code scenario, add the error code > '-EINVAL' to the return value 'ret'. > > Eliminate the follow smatch warning: > > drivers/fpga/machxo2-spi.c:341 machxo2_write_complete() warn: missing > error code 'ret'. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 > support") This shouldn't line-break. > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/fpga/machxo2-spi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c > index b4a530a..ea2ec3c 100644 > --- a/drivers/fpga/machxo2-spi.c > +++ b/drivers/fpga/machxo2-spi.c > @@ -338,6 +338,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr, > break; > if (++refreshloop == MACHXO2_MAX_REFRESH_LOOP) { > machxo2_cleanup(mgr); > + ret = -EINVAL; > goto fail; > } > } while (1); > -- > 1.8.3.1 > Applied to 'fixes' with modifications to commit message, Moritz
diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c index b4a530a..ea2ec3c 100644 --- a/drivers/fpga/machxo2-spi.c +++ b/drivers/fpga/machxo2-spi.c @@ -338,6 +338,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr, break; if (++refreshloop == MACHXO2_MAX_REFRESH_LOOP) { machxo2_cleanup(mgr); + ret = -EINVAL; goto fail; } } while (1);
The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'ret'. Eliminate the follow smatch warning: drivers/fpga/machxo2-spi.c:341 machxo2_write_complete() warn: missing error code 'ret'. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 support") Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/fpga/machxo2-spi.c | 1 + 1 file changed, 1 insertion(+)