| Message ID | 20171027201951.GA27077@embeddedor.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Fri, Oct 27, 2017 at 08:19:51PM +0000, Gustavo A. R. Silva wrote: > Notice that bridge = to_fpga_bridge(dev); expands to: > > bridge = container_of(dev, struct fpga_bridge, dev); > > and container_of is never null, so this null check is > unnecessary. > > Addresses-Coverity-ID: 1397912 > Reported-by: Alan Tull <atull@kernel.org> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Reviewed-by: Moritz Fischer <mdf@kernel.org> > --- > drivers/fpga/fpga-bridge.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c > index 9651aa5..409d1ac 100644 > --- a/drivers/fpga/fpga-bridge.c > +++ b/drivers/fpga/fpga-bridge.c > @@ -94,8 +94,6 @@ struct fpga_bridge *of_fpga_bridge_get(struct device_node *np, > goto err_dev; > > bridge = to_fpga_bridge(dev); > - if (!bridge) > - goto err_dev; > > bridge->info = info; > > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fpga" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks for the fix, Moritz -- To unsubscribe from this list: send the line "unsubscribe linux-fpga" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Moritz, Quoting Moritz Fischer <mdf@kernel.org>: > On Fri, Oct 27, 2017 at 08:19:51PM +0000, Gustavo A. R. Silva wrote: >> Notice that bridge = to_fpga_bridge(dev); expands to: >> >> bridge = container_of(dev, struct fpga_bridge, dev); >> >> and container_of is never null, so this null check is >> unnecessary. >> >> Addresses-Coverity-ID: 1397912 >> Reported-by: Alan Tull <atull@kernel.org> >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > Reviewed-by: Moritz Fischer <mdf@kernel.org> >> --- >> drivers/fpga/fpga-bridge.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c >> index 9651aa5..409d1ac 100644 >> --- a/drivers/fpga/fpga-bridge.c >> +++ b/drivers/fpga/fpga-bridge.c >> @@ -94,8 +94,6 @@ struct fpga_bridge *of_fpga_bridge_get(struct >> device_node *np, >> goto err_dev; >> >> bridge = to_fpga_bridge(dev); >> - if (!bridge) >> - goto err_dev; >> >> bridge->info = info; >> >> -- >> 2.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > Thanks for the fix, > Glad to help. Thanks -- Gustavo A. R. Silva -- To unsubscribe from this list: send the line "unsubscribe linux-fpga" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Oct 28, 2017 at 12:15 PM, Moritz Fischer <mdf@kernel.org> wrote: Hi Gustavo, Thanks! Alan > On Fri, Oct 27, 2017 at 08:19:51PM +0000, Gustavo A. R. Silva wrote: >> Notice that bridge = to_fpga_bridge(dev); expands to: >> >> bridge = container_of(dev, struct fpga_bridge, dev); >> >> and container_of is never null, so this null check is >> unnecessary. >> >> Addresses-Coverity-ID: 1397912 >> Reported-by: Alan Tull <atull@kernel.org> >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > Reviewed-by: Moritz Fischer <mdf@kernel.org> Signed-off-by: Alan Tull <atull@kernel.org> >> --- >> drivers/fpga/fpga-bridge.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c >> index 9651aa5..409d1ac 100644 >> --- a/drivers/fpga/fpga-bridge.c >> +++ b/drivers/fpga/fpga-bridge.c >> @@ -94,8 +94,6 @@ struct fpga_bridge *of_fpga_bridge_get(struct device_node *np, >> goto err_dev; >> >> bridge = to_fpga_bridge(dev); >> - if (!bridge) >> - goto err_dev; >> >> bridge->info = info; >> >> -- >> 2.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > Thanks for the fix, > > Moritz -- To unsubscribe from this list: send the line "unsubscribe linux-fpga" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Alan, Quoting Alan Tull <atull@kernel.org>: > On Sat, Oct 28, 2017 at 12:15 PM, Moritz Fischer <mdf@kernel.org> wrote: > > Hi Gustavo, > > Thanks! > Glad to help. :) Thanks -- Gustavo A. R. Silva -- To unsubscribe from this list: send the line "unsubscribe linux-fpga" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c index 9651aa5..409d1ac 100644 --- a/drivers/fpga/fpga-bridge.c +++ b/drivers/fpga/fpga-bridge.c @@ -94,8 +94,6 @@ struct fpga_bridge *of_fpga_bridge_get(struct device_node *np, goto err_dev; bridge = to_fpga_bridge(dev); - if (!bridge) - goto err_dev; bridge->info = info;
Notice that bridge = to_fpga_bridge(dev); expands to: bridge = container_of(dev, struct fpga_bridge, dev); and container_of is never null, so this null check is unnecessary. Addresses-Coverity-ID: 1397912 Reported-by: Alan Tull <atull@kernel.org> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/fpga/fpga-bridge.c | 2 -- 1 file changed, 2 deletions(-)