| Message ID | 20190114223312.3254-1-atull@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v2] fpga: altera_freeze_bridge: remove restriction to socfpga | expand |
minor nit On 1/14/19 4:33 PM, Alan Tull wrote: > The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA > since it can be used on other platforms such as Stratix10. > > Signed-off-by: Alan Tull <atull@kernel.org> > --- > drivers/fpga/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index 0bb7b5c..da5786a 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -104,7 +104,8 @@ config SOCFPGA_FPGA_BRIDGE > > config ALTERA_FREEZE_BRIDGE > tristate "Altera FPGA Freeze Bridge" > - depends on ARCH_SOCFPGA && FPGA_BRIDGE > + depends on FPGA_BRIDGE > + depends on HAS_IOMEM can just be: depends on FPGA_BRIDGE && HAS_IOMEM Dinh
On Tue, Jan 15, 2019 at 11:47 AM Dinh Nguyen <dinguyen@kernel.org> wrote: > > minor nit > > On 1/14/19 4:33 PM, Alan Tull wrote: > > The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA > > since it can be used on other platforms such as Stratix10. > > > > Signed-off-by: Alan Tull <atull@kernel.org> > > --- > > drivers/fpga/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > > index 0bb7b5c..da5786a 100644 > > --- a/drivers/fpga/Kconfig > > +++ b/drivers/fpga/Kconfig > > @@ -104,7 +104,8 @@ config SOCFPGA_FPGA_BRIDGE > > > > config ALTERA_FREEZE_BRIDGE > > tristate "Altera FPGA Freeze Bridge" > > - depends on ARCH_SOCFPGA && FPGA_BRIDGE > > + depends on FPGA_BRIDGE > > + depends on HAS_IOMEM > > can just be: > > depends on FPGA_BRIDGE && HAS_IOMEM I agree. > > Dinh
diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig index 0bb7b5c..da5786a 100644 --- a/drivers/fpga/Kconfig +++ b/drivers/fpga/Kconfig @@ -104,7 +104,8 @@ config SOCFPGA_FPGA_BRIDGE config ALTERA_FREEZE_BRIDGE tristate "Altera FPGA Freeze Bridge" - depends on ARCH_SOCFPGA && FPGA_BRIDGE + depends on FPGA_BRIDGE + depends on HAS_IOMEM help Say Y to enable drivers for Altera FPGA Freeze bridges. A freeze bridge is a bridge that exists in the FPGA fabric to
The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA since it can be used on other platforms such as Stratix10. Signed-off-by: Alan Tull <atull@kernel.org> --- drivers/fpga/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)