diff mbox series

fpga: stratix10-soc: fix typo in a comment

Message ID 20211212031956.46029-1-wangborong@cdjrlc.com (mailing list archive)
State New
Headers show
Series fpga: stratix10-soc: fix typo in a comment | expand

Commit Message

Jason Wang Dec. 12, 2021, 3:19 a.m. UTC 
The double `if' in the comment in line 288 is repeated. Remove one
of them from the comment.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 drivers/fpga/stratix10-soc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rix Dec. 12, 2021, 4:19 p.m. UTC | #1 
On 12/11/21 7:19 PM, Jason Wang wrote:
> The double `if' in the comment in line 288 is repeated. Remove one
> of them from the comment.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>   drivers/fpga/stratix10-soc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 357cea58ec98..e4f2e83a615b 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -285,7 +285,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
>   
>   	/*
>   	 * Loop waiting for buffers to be returned.  When a buffer is returned,
> -	 * reuse it to send more data or free if if all data has been sent.
> +	 * reuse it to send more data or free if all data has been sent.

This looks fine.

Reviewed-by: Tom Rix <trix@redhat.com>

>   	 */
>   	while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
>   		reinit_completion(&priv->status_return_completion);
Xu Yilun Dec. 13, 2021, 1:28 a.m. UTC | #2 
On Sun, Dec 12, 2021 at 08:19:00AM -0800, Tom Rix wrote:
> 
> On 12/11/21 7:19 PM, Jason Wang wrote:
> > The double `if' in the comment in line 288 is repeated. Remove one
> > of them from the comment.
> > 
> > Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> > ---
> >   drivers/fpga/stratix10-soc.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> > index 357cea58ec98..e4f2e83a615b 100644
> > --- a/drivers/fpga/stratix10-soc.c
> > +++ b/drivers/fpga/stratix10-soc.c
> > @@ -285,7 +285,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
> >   	/*
> >   	 * Loop waiting for buffers to be returned.  When a buffer is returned,
> > -	 * reuse it to send more data or free if if all data has been sent.
> > +	 * reuse it to send more data or free if all data has been sent.
> 
> This looks fine.
> 
> Reviewed-by: Tom Rix <trix@redhat.com>

Acked-by: Xu Yilun <yilun.xu@intel.com>

Thanks,
Yilun

> 
> >   	 */
> >   	while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
> >   		reinit_completion(&priv->status_return_completion);
diff mbox series

Patch

diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
index 357cea58ec98..e4f2e83a615b 100644
--- a/drivers/fpga/stratix10-soc.c
+++ b/drivers/fpga/stratix10-soc.c
@@ -285,7 +285,7 @@  static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
 
 	/*
 	 * Loop waiting for buffers to be returned.  When a buffer is returned,
-	 * reuse it to send more data or free if if all data has been sent.
+	 * reuse it to send more data or free if all data has been sent.
 	 */
 	while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
 		reinit_completion(&priv->status_return_completion);