| Message ID | 20220322082202.2007321-3-nava.manne@xilinx.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fpga: fix for coding style and kernel-doc issues | expand |
On 3/22/22 1:21 AM, Nava kishore Manne wrote: > fixes the below checks reported by checkpatch.pl > Lines should not end with a '(' > Alignment should match open parenthesis There are more than a few similar alignments to clean up in drivers/fpga Instead of just one, in a separate patchset, clean up all of them. Tom > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> > --- > Changes for v2: > -None. > > drivers/fpga/fpga-mgr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c > index d49a9ce34568..a699cc8e2fa6 100644 > --- a/drivers/fpga/fpga-mgr.c > +++ b/drivers/fpga/fpga-mgr.c > @@ -151,8 +151,8 @@ static int fpga_mgr_write_init_buf(struct fpga_manager *mgr, > if (!mgr->mops->initial_header_size) > ret = fpga_mgr_write_init(mgr, info, NULL, 0); > else > - ret = fpga_mgr_write_init( > - mgr, info, buf, min(mgr->mops->initial_header_size, count)); > + ret = fpga_mgr_write_init(mgr, info, buf, > + min(mgr->mops->initial_header_size, count)); > > if (ret) { > dev_err(&mgr->dev, "Error preparing FPGA for writing\n");
Hi Tom, Thanks for providing the review comments. Please find my response inline. > -----Original Message----- > From: Tom Rix <trix@redhat.com> > Sent: Saturday, March 26, 2022 10:33 PM > To: Nava kishore Manne <navam@xilinx.com>; mdf@kernel.org; > hao.wu@intel.com; yilun.xu@intel.com; Michal Simek > <michals@xilinx.com>; linux-fpga@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; git > <git@xilinx.com> > Subject: Re: [PATCH v2 2/5] fpga: fpga-mgr: fix for coding style issues > > > On 3/22/22 1:21 AM, Nava kishore Manne wrote: > > fixes the below checks reported by checkpatch.pl Lines should not end > > with a '(' > > Alignment should match open parenthesis > > There are more than a few similar alignments to clean up in drivers/fpga > > Instead of just one, in a separate patchset, clean up all of them. > Will fix in v3. Regards, Navakishore.
diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index d49a9ce34568..a699cc8e2fa6 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -151,8 +151,8 @@ static int fpga_mgr_write_init_buf(struct fpga_manager *mgr, if (!mgr->mops->initial_header_size) ret = fpga_mgr_write_init(mgr, info, NULL, 0); else - ret = fpga_mgr_write_init( - mgr, info, buf, min(mgr->mops->initial_header_size, count)); + ret = fpga_mgr_write_init(mgr, info, buf, + min(mgr->mops->initial_header_size, count)); if (ret) { dev_err(&mgr->dev, "Error preparing FPGA for writing\n");
fixes the below checks reported by checkpatch.pl Lines should not end with a '(' Alignment should match open parenthesis Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> --- Changes for v2: -None. drivers/fpga/fpga-mgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)