| Message ID | 20220525151453.55725-1-marpagan@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] fpga: altera-pr-ip: fix unsigned comparison with less than zero | expand |
On Wed, May 25, 2022 at 05:14:52PM +0200, Marco Pagani wrote: > Fix the "comparison with less than zero" warning reported by > cppcheck for the unsigned (size_t) parameter count of the > alt_pr_fpga_write() function. > Please add the 'Fixes' tag, and resend it based on 5.19-rc1 Thanks, Yilun > Reviewed-by: Tom Rix <trix@redhat.com> > Acked-by: Xu Yilun <yilun.xu@intel.com> > Signed-off-by: Marco Pagani <marpagan@redhat.com> > --- > Changes v1 -> v2: > - Coding style fix > --- > drivers/fpga/altera-pr-ip-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c > index be0667968d33..df8671af4a92 100644 > --- a/drivers/fpga/altera-pr-ip-core.c > +++ b/drivers/fpga/altera-pr-ip-core.c > @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf, > u32 *buffer_32 = (u32 *)buf; > size_t i = 0; > > - if (count <= 0) > + if (!count) > return -EINVAL; > > /* Write out the complete 32-bit chunks */ > -- > 2.35.3
diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c index be0667968d33..df8671af4a92 100644 --- a/drivers/fpga/altera-pr-ip-core.c +++ b/drivers/fpga/altera-pr-ip-core.c @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf, u32 *buffer_32 = (u32 *)buf; size_t i = 0; - if (count <= 0) + if (!count) return -EINVAL; /* Write out the complete 32-bit chunks */