[v5,02/18] fscrypt: add fscrypt_have_same_policy() to check inode compatibility

Commit Message

Sweet Tea Dorminy Nov. 2, 2022, 11:52 a.m. UTC

From: Omar Sandoval <[e-mail]>

Btrfs will need to check whether inode policies are identical for
various purposes: if two inodes want to share an extent, they must have
the same policy, including key identifier; symlinks must not span the
encrypted/unencrypted border; and certain encryption policies will allow
btrfs to store one fscrypt_context for multiple objects. Therefore, add
a function which allows checking the encryption policies of two inodes
to ensure they are identical.

Signed-off-by: Omar Sandoval <[e-mail]>
Signed-off-by: Sweet Tea Dorminy <[e-mail]>
---
 fs/crypto/policy.c      | 35 +++++++++++++++++++++++++++++++++++
 include/linux/fscrypt.h |  8 ++++++++
 2 files changed, 43 insertions(+)

Patch

diff --git a/fs/crypto/policy.c b/fs/crypto/policy.c
index 46757c3052ef..715870d4e530 100644
--- a/fs/crypto/policy.c
+++ b/fs/crypto/policy.c
@@ -415,6 +415,41 @@  static int fscrypt_get_policy(struct inode *inode, union fscrypt_policy *policy)
 	return fscrypt_policy_from_context(policy, &ctx, ret);
 }
 
+/**
+ * fscrypt_have_same_policy() - check whether two inodes have the same policy
+ * @inode1: the first inode
+ * @inode2: the second inode
+ * @same_ptr: a pointer to return whether they are the same
+ *
+ * Return: 0 or an error code.
+ */
+int fscrypt_have_same_policy(struct inode *inode1, struct inode *inode2,
+			     bool *same_ptr)
+{
+	union fscrypt_policy policy1, policy2;
+	int err;
+
+	if (!IS_ENCRYPTED(inode1) && !IS_ENCRYPTED(inode2)) {
+		*same_ptr = true;
+		return 0;
+	}
+	if (!IS_ENCRYPTED(inode1) || !IS_ENCRYPTED(inode2)) {
+		*same_ptr = false;
+		return 0;
+	}
+
+	err = fscrypt_get_policy(inode1, &policy1);
+	if (err)
+		return err;
+	err = fscrypt_get_policy(inode2, &policy2);
+	if (err)
+		return err;
+
+	*same_ptr = fscrypt_policies_equal(&policy1, &policy2);
+	return 0;
+}
+EXPORT_SYMBOL(fscrypt_have_same_policy);
+
 static int set_encryption_policy(struct inode *inode,
 				 const union fscrypt_policy *policy)
 {
diff --git a/include/linux/fscrypt.h b/include/linux/fscrypt.h
index 7661db0b5bec..0069f92ee3da 100644
--- a/include/linux/fscrypt.h
+++ b/include/linux/fscrypt.h
@@ -313,6 +313,8 @@  static inline struct page *fscrypt_pagecache_page(struct page *bounce_page)
 void fscrypt_free_bounce_page(struct page *bounce_page);
 
 /* policy.c */
+int fscrypt_have_same_policy(struct inode *inode1, struct inode *inode2,
+			     bool *same_ptr);
 int fscrypt_ioctl_set_policy(struct file *filp, const void __user *arg);
 int fscrypt_ioctl_get_policy(struct file *filp, void __user *arg);
 int fscrypt_ioctl_get_policy_ex(struct file *filp, void __user *arg);
@@ -490,6 +492,12 @@  static inline void fscrypt_free_bounce_page(struct page *bounce_page)
 }
 
 /* policy.c */
+static inline int fscrypt_have_same_policy(struct inode *inode1,
+					   struct inode *inode2)
+{
+	return 1;
+}
+
 static inline int fscrypt_ioctl_set_policy(struct file *filp,
 					   const void __user *arg)
 {