| Message ID | 20170406231428.154187-1-joerichey94@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Am 07.04.2017 um 01:14 schrieb Joe Richey: > From: Joe Richey <joerichey@google.com> > > This commit removes __packed from fscrypt_policy as it does not contain > any implicit padding and does not refer to an on-disk structure. Even > though this is a change to a UAPI file, no users will be broken as the > structure doesn't change. > > Signed-off-by: Joe Richey <joerichey@google.com> > --- > include/uapi/linux/fs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h > index 048a85e9f017..f6e1c54ac5e2 100644 > --- a/include/uapi/linux/fs.h > +++ b/include/uapi/linux/fs.h > @@ -279,7 +279,7 @@ struct fscrypt_policy { > __u8 filenames_encryption_mode; > __u8 flags; > __u8 master_key_descriptor[FS_KEY_DESCRIPTOR_SIZE]; > -} __packed; > +}; Both patches are fine, just keep my Reviewed-by. :) Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-fscrypt" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 06, 2017 at 04:14:28PM -0700, Joe Richey wrote: > From: Joe Richey <joerichey@google.com> > > This commit removes __packed from fscrypt_policy as it does not contain > any implicit padding and does not refer to an on-disk structure. Even > though this is a change to a UAPI file, no users will be broken as the > structure doesn't change. > > Signed-off-by: Joe Richey <joerichey@google.com> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-fscrypt" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h index 048a85e9f017..f6e1c54ac5e2 100644 --- a/include/uapi/linux/fs.h +++ b/include/uapi/linux/fs.h @@ -279,7 +279,7 @@ struct fscrypt_policy { __u8 filenames_encryption_mode; __u8 flags; __u8 master_key_descriptor[FS_KEY_DESCRIPTOR_SIZE]; -} __packed; +}; #define FS_IOC_SET_ENCRYPTION_POLICY _IOR('f', 19, struct fscrypt_policy) #define FS_IOC_GET_ENCRYPTION_PWSALT _IOW('f', 20, __u8[16])