mbox series

[0/5] y2038: Make ppoll, io_pgetevents and pselect y2038 safe

Message ID 20180901204721.13117-1-deepa.kernel@gmail.com (mailing list archive)
Headers show
Series y2038: Make ppoll, io_pgetevents and pselect y2038 safe | expand

Message

Deepa Dinamani Sept. 1, 2018, 8:47 p.m. UTC 
The series transitions the ppoll, io_getevents, and pselect syscalls
to be y2038 safe.

This is part of the work proceeding for syscalls for y2038.
It is based on the series [1] from Arnd Bergmann.

The overview of the series is as below:
1. Refactor sigmask handling logic for the above syscalls.
2. Provide y2038 safe versions of syscalls for all ABIs.

[1] https://lkml.org/lkml/2018/8/27/651

Deepa Dinamani (5):
  signal: Add set_user_sigmask()
  signal: Add restore_user_sigmask()
  ppoll: use __kernel_timespec
  pselect6: use __kernel_timespec
  io_pgetevents: use __kernel_timespec

 fs/aio.c                 | 138 ++++++++++-----
 fs/eventpoll.c           |  52 +-----
 fs/select.c              | 367 +++++++++++++++++++++++----------------
 include/linux/compat.h   |  20 +++
 include/linux/signal.h   |   4 +
 include/linux/syscalls.h |  20 ++-
 kernel/signal.c          |  78 +++++++++
 7 files changed, 437 insertions(+), 242 deletions(-)

Comments

Arnd Bergmann Sept. 14, 2018, 4:06 p.m. UTC | #1 
On Sat, Sep 1, 2018 at 10:48 PM Deepa Dinamani <deepa.kernel@gmail.com> wrote:
>
> The series transitions the ppoll, io_getevents, and pselect syscalls
> to be y2038 safe.
>
> This is part of the work proceeding for syscalls for y2038.
> It is based on the series [1] from Arnd Bergmann.
>
> The overview of the series is as below:
> 1. Refactor sigmask handling logic for the above syscalls.
> 2. Provide y2038 safe versions of syscalls for all ABIs.
>
> [1] https://lkml.org/lkml/2018/8/27/651

Hi Deepa,

This is a very nice series, sorry for taking way too long before
I had a good look at it.

The first two patches in particular are great. The third patch
looks like it has a small bug that I commented on, but given
how much more thought you have put into this than I did, it's
just as possible that I misunderstood it.

I've applied you series locally now, but have not pushed it out
yet for linux-next because of that one issue. I'll send a pull
request to Thomas for my other patches for now, and a
follow-up with these once we have clarified it.

        Arnd