[0/2] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name

Message

Eugene Syromiatnikov Oct. 6, 2018, 5:51 p.m. UTC

Hello.

This is a small fix of a typo (or, more specifically, some remnant of
the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
which is named as RWF_WRITE_LIFE_NOT_SET currently.  Since the name
with "H" is used in man page and everywhere else, it's probably worth
to make the name used in the fcntl.h UAPI header in line with it.
Second follow-up patch updates (the sole) usage site of this constant
in kernel to use the new spelling.

The old name is retained as it is part of UAPI now.

Eugene Syromiatnikov (2):
  fcntl: fix typo in RWH_WRITE_LIFE_NOT_SET r/w hint
  drivers/md/raid5.c: use the new spelling of RWH_WRITE_LIFE_NOT_SET

 drivers/md/raid5.c               | 4 ++--
 fs/fcntl.c                       | 2 +-
 include/uapi/linux/fcntl.h       | 9 ++++++++-
 tools/include/uapi/linux/fcntl.h | 9 ++++++++-
 4 files changed, 19 insertions(+), 5 deletions(-)

Comments

Eugene Syromiatnikov Oct. 25, 2018, 2:19 p.m. UTC | #1

On Sat, Oct 06, 2018 at 07:51:14PM +0200, Eugene Syromiatnikov wrote:
> Hello.
> 
> This is a small fix of a typo (or, more specifically, some remnant of
> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
> which is named as RWF_WRITE_LIFE_NOT_SET currently.  Since the name
> with "H" is used in man page and everywhere else, it's probably worth
> to make the name used in the fcntl.h UAPI header in line with it.
> Second follow-up patch updates (the sole) usage site of this constant
> in kernel to use the new spelling.
> 
> The old name is retained as it is part of UAPI now.

Hello, are there issues with the patches?

> Eugene Syromiatnikov (2):
>   fcntl: fix typo in RWH_WRITE_LIFE_NOT_SET r/w hint
>   drivers/md/raid5.c: use the new spelling of RWH_WRITE_LIFE_NOT_SET
> 
>  drivers/md/raid5.c               | 4 ++--
>  fs/fcntl.c                       | 2 +-
>  include/uapi/linux/fcntl.h       | 9 ++++++++-
>  tools/include/uapi/linux/fcntl.h | 9 ++++++++-
>  4 files changed, 19 insertions(+), 5 deletions(-)
> 
> -- 
> 2.1.4
>

Jens Axboe Oct. 25, 2018, 2:25 p.m. UTC | #2

On 10/25/18 8:19 AM, Eugene Syromiatnikov wrote:
> On Sat, Oct 06, 2018 at 07:51:14PM +0200, Eugene Syromiatnikov wrote:
>> Hello.
>>
>> This is a small fix of a typo (or, more specifically, some remnant of
>> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
>> which is named as RWF_WRITE_LIFE_NOT_SET currently.  Since the name
>> with "H" is used in man page and everywhere else, it's probably worth
>> to make the name used in the fcntl.h UAPI header in line with it.
>> Second follow-up patch updates (the sole) usage site of this constant
>> in kernel to use the new spelling.
>>
>> The old name is retained as it is part of UAPI now.
> 
> Hello, are there issues with the patches?

I only got the 0/2 patch, none of the two others..

Eugene Syromiatnikov Oct. 25, 2018, 3 p.m. UTC | #3

On Thu, Oct 25, 2018 at 08:25:44AM -0600, Jens Axboe wrote:
> On 10/25/18 8:19 AM, Eugene Syromiatnikov wrote:
> > On Sat, Oct 06, 2018 at 07:51:14PM +0200, Eugene Syromiatnikov wrote:
> >> Hello.
> >>
> >> This is a small fix of a typo (or, more specifically, some remnant of
> >> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
> >> which is named as RWF_WRITE_LIFE_NOT_SET currently.  Since the name
> >> with "H" is used in man page and everywhere else, it's probably worth
> >> to make the name used in the fcntl.h UAPI header in line with it.
> >> Second follow-up patch updates (the sole) usage site of this constant
> >> in kernel to use the new spelling.
> >>
> >> The old name is retained as it is part of UAPI now.
> > 
> > Hello, are there issues with the patches?
> 
> I only got the 0/2 patch, none of the two others..

Uh, sorry, I see them on lkml[1][2], but likely have messed up git
format-patch options, as I usually do. Will resend shortly.

[1] https://lkml.org/lkml/2018/10/6/292
[2] https://lkml.org/lkml/2018/10/6/291

> -- 
> Jens Axboe
>