[0/2] exfat: allow access to paths with trailing dots

Message

David Disseldorp Aug. 18, 2021, 11:11 a.m. UTC

This patchset adds a new exfat "keeptail" mount option, which allows
users to resolve paths carrying trailing period '.' characters.
I'm not a huge fan of "keeptail" as an option name, but couldn't think
of anything better.

Feedback appreciated.

Cheers, David

--

 fs/exfat/exfat_fs.h |  3 ++-
 fs/exfat/namei.c    | 25 ++++++++++++++-----------
 fs/exfat/super.c    |  7 +++++++
 3 files changed, 23 insertions(+), 12 deletions(-)

Comments

Christian Brauner Aug. 18, 2021, 12:48 p.m. UTC | #1

On Wed, Aug 18, 2021 at 01:11:21PM +0200, David Disseldorp wrote:
> This patchset adds a new exfat "keeptail" mount option, which allows
> users to resolve paths carrying trailing period '.' characters.
> I'm not a huge fan of "keeptail" as an option name, but couldn't think
> of anything better.

I wouldn't use "period". The vfs uses "dot" and "dotdot" as seen in e.g.
LAST_DOT or LAST_DOTOT. Maybe "keep_last_dot"?

Christian

David Disseldorp Aug. 18, 2021, 4:40 p.m. UTC | #2

On Wed, 18 Aug 2021 14:48:35 +0200, Christian Brauner wrote:

> On Wed, Aug 18, 2021 at 01:11:21PM +0200, David Disseldorp wrote:
> > This patchset adds a new exfat "keeptail" mount option, which allows
> > users to resolve paths carrying trailing period '.' characters.
> > I'm not a huge fan of "keeptail" as an option name, but couldn't think
> > of anything better.  
> 
> I wouldn't use "period". The vfs uses "dot" and "dotdot" as seen in e.g.
> LAST_DOT or LAST_DOTOT. Maybe "keep_last_dot"?

Works for me, although I was under the impression that underscores were
avoided for mount options. Also, I think it'd be clearer as the plural
"keep_last_dots".

Cheers, David

Christian Brauner Aug. 18, 2021, 5:49 p.m. UTC | #3

On Wed, Aug 18, 2021 at 06:40:16PM +0200, David Disseldorp wrote:
> On Wed, 18 Aug 2021 14:48:35 +0200, Christian Brauner wrote:
> 
> > On Wed, Aug 18, 2021 at 01:11:21PM +0200, David Disseldorp wrote:
> > > This patchset adds a new exfat "keeptail" mount option, which allows
> > > users to resolve paths carrying trailing period '.' characters.
> > > I'm not a huge fan of "keeptail" as an option name, but couldn't think
> > > of anything better.  
> > 
> > I wouldn't use "period". The vfs uses "dot" and "dotdot" as seen in e.g.
> > LAST_DOT or LAST_DOTOT. Maybe "keep_last_dot"?
> 
> Works for me, although I was under the impression that underscores were
> avoided for mount options. Also, I think it'd be clearer as the plural

Oh? I' just - for unrelated reasons - looking at cifs code and I
immediately see:

min_enc_offload
max_credits
_netdev

which doesn't necessarily mean that I'm right but rather that that ship
might have sailed. :)

Christian