| Message ID | 20220318093706.161534-1-bhe@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Convert vmcore to use an iov_iter | expand |
Forgot adding Andrew to CC, add him. On 03/18/22 at 05:37pm, Baoquan He wrote: > Copy the description of v3 cover letter from Willy: > === > For some reason several people have been sending bad patches to fix > compiler warnings in vmcore recently. Here's how it should be done. > Compile-tested only on x86. As noted in the first patch, s390 should > take this conversion a bit further, but I'm not inclined to do that > work myself. > > This series resends Willy's v3 patches which includes patch 1~3, and > append one patch to clean up the open code pointed out by Al. > > Al's concerns to v3 patches and my reply after investigation: > https://lore.kernel.org/all/YhiTN0MORoQmFFkO@MiWiFi-R3L-srv/T/#u > > Willy's v3 patchset: > [PATCH v3 0/3] Convert vmcore to use an iov_iter > https://lore.kernel.org/all/20211213143927.3069508-1-willy@infradead.org/T/#u > > Changelog: > === > v4: > - Append one patch to replace the open code with iov_iter_count(). > This is suggested by Al. > - Fix a indentation error by replacing space with tab in > arch/sh/kernel/crash_dump.c of patch 1 reported by checkpatch. The > rest of patch 1~3 are untouched. > - Add Christopy's Reviewed-by and my Acked-by for patch 1~3. > v3: > - Send the correct patches this time > v2: > - Removed unnecessary kernel-doc > - Included uio.h to fix compilation problems > - Made read_from_oldmem_iter static to avoid compile warnings during the > conversion > - Use iov_iter_truncate() (Christoph) > > > > Baoquan He (1): > fs/proc/vmcore: Use iov_iter_count() > > Matthew Wilcox (Oracle) (3): > vmcore: Convert copy_oldmem_page() to take an iov_iter > vmcore: Convert __read_vmcore to use an iov_iter > vmcore: Convert read_from_oldmem() to take an iov_iter > > arch/arm/kernel/crash_dump.c | 27 +------ > arch/arm64/kernel/crash_dump.c | 29 +------ > arch/ia64/kernel/crash_dump.c | 32 +------- > arch/mips/kernel/crash_dump.c | 27 +------ > arch/powerpc/kernel/crash_dump.c | 35 ++------- > arch/riscv/kernel/crash_dump.c | 26 +------ > arch/s390/kernel/crash_dump.c | 13 ++-- > arch/sh/kernel/crash_dump.c | 29 ++----- > arch/x86/kernel/crash_dump_32.c | 29 +------ > arch/x86/kernel/crash_dump_64.c | 48 ++++-------- > fs/proc/vmcore.c | 130 +++++++++++++------------------ > include/linux/crash_dump.h | 19 ++--- > 12 files changed, 123 insertions(+), 321 deletions(-) > > -- > 2.34.1 >
Hi Andrew, On 03/18/22 at 05:37pm, Baoquan He wrote: > Copy the description of v3 cover letter from Willy: Could you pick this series into your tree? I reviewed the patches 1~3 and tested the whole patchset, no issue found. Thanks Baoquan > === > For some reason several people have been sending bad patches to fix > compiler warnings in vmcore recently. Here's how it should be done. > Compile-tested only on x86. As noted in the first patch, s390 should > take this conversion a bit further, but I'm not inclined to do that > work myself. > > This series resends Willy's v3 patches which includes patch 1~3, and > append one patch to clean up the open code pointed out by Al. > > Al's concerns to v3 patches and my reply after investigation: > https://lore.kernel.org/all/YhiTN0MORoQmFFkO@MiWiFi-R3L-srv/T/#u > > Willy's v3 patchset: > [PATCH v3 0/3] Convert vmcore to use an iov_iter > https://lore.kernel.org/all/20211213143927.3069508-1-willy@infradead.org/T/#u > > Changelog: > === > v4: > - Append one patch to replace the open code with iov_iter_count(). > This is suggested by Al. > - Fix a indentation error by replacing space with tab in > arch/sh/kernel/crash_dump.c of patch 1 reported by checkpatch. The > rest of patch 1~3 are untouched. > - Add Christopy's Reviewed-by and my Acked-by for patch 1~3. > v3: > - Send the correct patches this time > v2: > - Removed unnecessary kernel-doc > - Included uio.h to fix compilation problems > - Made read_from_oldmem_iter static to avoid compile warnings during the > conversion > - Use iov_iter_truncate() (Christoph) > > > > Baoquan He (1): > fs/proc/vmcore: Use iov_iter_count() > > Matthew Wilcox (Oracle) (3): > vmcore: Convert copy_oldmem_page() to take an iov_iter > vmcore: Convert __read_vmcore to use an iov_iter > vmcore: Convert read_from_oldmem() to take an iov_iter > > arch/arm/kernel/crash_dump.c | 27 +------ > arch/arm64/kernel/crash_dump.c | 29 +------ > arch/ia64/kernel/crash_dump.c | 32 +------- > arch/mips/kernel/crash_dump.c | 27 +------ > arch/powerpc/kernel/crash_dump.c | 35 ++------- > arch/riscv/kernel/crash_dump.c | 26 +------ > arch/s390/kernel/crash_dump.c | 13 ++-- > arch/sh/kernel/crash_dump.c | 29 ++----- > arch/x86/kernel/crash_dump_32.c | 29 +------ > arch/x86/kernel/crash_dump_64.c | 48 ++++-------- > fs/proc/vmcore.c | 130 +++++++++++++------------------ > include/linux/crash_dump.h | 19 ++--- > 12 files changed, 123 insertions(+), 321 deletions(-) > > -- > 2.34.1 >
On Thu, Mar 31, 2022 at 07:25:33PM +0800, Baoquan He wrote: > Hi Andrew, > > On 03/18/22 at 05:37pm, Baoquan He wrote: > > Copy the description of v3 cover letter from Willy: > > Could you pick this series into your tree? I reviewed the patches 1~3 > and tested the whole patchset, no issue found. ... I'd fold patch 4 into patch 1, but yes, Andrew, please take these patches.
On Thu, 31 Mar 2022 15:36:39 +0100 Matthew Wilcox <willy@infradead.org> wrote: > On Thu, Mar 31, 2022 at 07:25:33PM +0800, Baoquan He wrote: > > Hi Andrew, > > > > On 03/18/22 at 05:37pm, Baoquan He wrote: > > > Copy the description of v3 cover letter from Willy: > > > > Could you pick this series into your tree? I reviewed the patches 1~3 > > and tested the whole patchset, no issue found. > > ... I'd fold patch 4 into patch 1, I think so too, please. The addition then removal of a read_from_oldmem() implementation is a bit odd. > but yes, Andrew, please take these patches. And against current -linus please. There have been some changes since then (rcu stuff).
On 03/31/22 at 05:14pm, Andrew Morton wrote: > On Thu, 31 Mar 2022 15:36:39 +0100 Matthew Wilcox <willy@infradead.org> wrote: > > > On Thu, Mar 31, 2022 at 07:25:33PM +0800, Baoquan He wrote: > > > Hi Andrew, > > > > > > On 03/18/22 at 05:37pm, Baoquan He wrote: > > > > Copy the description of v3 cover letter from Willy: > > > > > > Could you pick this series into your tree? I reviewed the patches 1~3 > > > and tested the whole patchset, no issue found. > > > > ... I'd fold patch 4 into patch 1, > > I think so too, please. The addition then removal of a > read_from_oldmem() implementation is a bit odd. > > > but yes, Andrew, please take these patches. > > And against current -linus please. There have been some changes since > then (rcu stuff). OK, I will fold 1 to 4, and send v5 based on linus's tree.