| Message ID | 20240222-sysctl-empty-dir-v1-0-45ba9a6352e8@weissschuh.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | sysctl: move sysctl type to ctl_table_header | expand |
On Thu, Feb 22, 2024 at 08:07:35AM +0100, Thomas Weißschuh wrote: > Praparation series to enable constification of struct ctl_table further > down the line. > No functional changes are intended. > > These changes have been split out and reworked from my original > const sysctl patchset [0]. > I'm resubmitting the patchset in smaller chunks for easier review. > Each split-out series is meant to be useful on its own. > > Changes since the original series: > * Explicit initializartion of header->type in init_header() > * Some additional cleanups > > [0] https://lore.kernel.org/lkml/20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net/ This all looks super sexy to me, but I'd love Eric's feedback on patch series before merging as he may know some other facts over sysctl_mount_point I might be missing. Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> Luis
On Thu, Feb 22, 2024 at 08:07:35AM +0100, Thomas Weißschuh wrote: > Praparation series to enable constification of struct ctl_table further > down the line. > No functional changes are intended. Took me some time but I finally got around to it. I just had comments regarding the commit messages. I'll add this to sysctl testing to get the ball rolling; I'll add it to sysctl-next after you modify the commit messages. Thx. > > These changes have been split out and reworked from my original > const sysctl patchset [0]. > I'm resubmitting the patchset in smaller chunks for easier review. > Each split-out series is meant to be useful on its own. > > Changes since the original series: > * Explicit initializartion of header->type in init_header() > * Some additional cleanups > > [0] https://lore.kernel.org/lkml/20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net/ > > --- > Thomas Weißschuh (4): > sysctl: drop sysctl_is_perm_empty_ctl_table > sysctl: move sysctl type to ctl_table_header > sysctl: drop now unnecessary out-of-bounds check > sysctl: remove unnecessary sentinel element > > fs/proc/proc_sysctl.c | 19 ++++++++----------- > include/linux/sysctl.h | 22 +++++++++++----------- > 2 files changed, 19 insertions(+), 22 deletions(-) > --- > base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d > change-id: 20231216-sysctl-empty-dir-71d7631f7bfe > > Best regards, > -- > Thomas Weißschuh <linux@weissschuh.net> >
Praparation series to enable constification of struct ctl_table further down the line. No functional changes are intended. These changes have been split out and reworked from my original const sysctl patchset [0]. I'm resubmitting the patchset in smaller chunks for easier review. Each split-out series is meant to be useful on its own. Changes since the original series: * Explicit initializartion of header->type in init_header() * Some additional cleanups [0] https://lore.kernel.org/lkml/20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net/ --- Thomas Weißschuh (4): sysctl: drop sysctl_is_perm_empty_ctl_table sysctl: move sysctl type to ctl_table_header sysctl: drop now unnecessary out-of-bounds check sysctl: remove unnecessary sentinel element fs/proc/proc_sysctl.c | 19 ++++++++----------- include/linux/sysctl.h | 22 +++++++++++----------- 2 files changed, 19 insertions(+), 22 deletions(-) --- base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d change-id: 20231216-sysctl-empty-dir-71d7631f7bfe Best regards,