From patchwork Mon Jun 10 19:20:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qais Yousef X-Patchwork-Id: 13692373 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B04E8381AD for ; Mon, 10 Jun 2024 19:20:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718047225; cv=none; b=f+2n0Rwetsmv5ock6pqwlXP4n9Qt/JfmBYoD+xTcuc90ZNumFkmVJ18ME7fLLK0h9KJDKTWfjcaR7TA2SXXnvr3GP2+cpXBz8pxbI8XcGqLCTXu8qLY6wE8TpnnRDCWlqAPkOW6gw6H0vMCyinybsO5+41vILq6p+ycFR/MtwVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718047225; c=relaxed/simple; bh=y6UMp+m9utYZgleNENyTjU9jhHksT+GMIMx/yKH2WLk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=YoHWfxZPg18EVs2Xa46sUquI6RCxUAYuf85WijfZagzyXRpB5K6PFwfXEHIfyro3m+7s6UfdIbeyc64lbdwCROhP/c7nHLTeK9ttNKAtDoTDe4n001zP6/WZ0eRvS9K5zZttO+1Fifk+032A7dyc0uUwzqoNPFKeXeEhcx3ugiU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io; spf=pass smtp.mailfrom=layalina.io; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b=hqVtsydn; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=layalina.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b="hqVtsydn" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-35f1c209893so2222946f8f.2 for ; Mon, 10 Jun 2024 12:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1718047222; x=1718652022; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Guz7MjyMNC45VGVGtnc1o6ogeR5taFihB6DV18NWqFk=; b=hqVtsydnmMw9Uvu8OGiLOStNOKANZ4ZbHr4i3N+JvxKxwT+Thf/Pg3H498Ao+y81Fr m4sOGnBErVW0Yi7PKL1p0W/bXQVLftRzi1ycZfAVJk2zZmEVblPiAG8iItsF2QZwm4GV slNX7uxO4uObcdCupaP4ZVJLIZFqE8Xr0joz/K0yvVY3WsIaaHeDcgSQajtflqrnsG+q aMppXrw4XvQdd5Ymr4ND92SQgu3ctIhRCaQX3xW7LokojoCup0CTdv16ZW5EbdAB1SAo EZr0r+Vzqd5bkQPJYLim/4iW8qRXWTK04lc8pZ3TNFphOWP4KvD56H4bt6wXHu9dlteX oUaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718047222; x=1718652022; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Guz7MjyMNC45VGVGtnc1o6ogeR5taFihB6DV18NWqFk=; b=kExX0pXK1OhRaek1JMG48hzYd6cecXuUHYt2iXh6x+0W7D9K901B46KS0h755cXxmO F3tGJSZFVB2GOVr1lQWwrjqy43XV3iqKUREg4DGUlXseiuZcsxtl93GJLyVu8wQBAYFi LcB+06MFFYTmPK5fVDG+NtZXuiI96Al4tRlxqXiWJw3h+khMFxAREoVQEBq3IN4q1G+4 lX3/DRTPVdYWUPK3IHgTbZIvfGsLRXuWTpEIb1HHz20jxeCInR/cJQfEec42OTVbbdvE hMglpKntip2EXplouSdvanesR1Ph7nihMVk+LVMITFj6tTM2SNIyfd4jWh/GcZ9jhAZM Fa5w== X-Forwarded-Encrypted: i=1; AJvYcCUVHbBuZaxn9MSaVLZbmvOmNBWHKxt8ngyoGK2+9/8W6nyb7ijIAPuFSd7i/o0yQM3D7gUH85/cY/JIIA4nv7HaHzQRqu/rFpgnj+PcMg== X-Gm-Message-State: AOJu0Yxk9d4KWnncXg+f6fbfo/IZ+T3/2xFOesic376z9sk4Ei3jykLN vG2R1t5xOi5Bxp8pgKeeCxO8LVqr8IfZ3Wo+g0IVU6ujcOOoKjR1SpXCl2bf5WM= X-Google-Smtp-Source: AGHT+IHq8jSEMkw7gwkS01+qTAl/yGpwM7w1xlBZWuVyZXGP6Ki1z+5dsHApq2plP2vN33SQwO/EeA== X-Received: by 2002:a05:6000:1886:b0:35f:17c8:fe2d with SMTP id ffacd0b85a97d-35f17c8ff54mr6394663f8f.37.1718047221959; Mon, 10 Jun 2024 12:20:21 -0700 (PDT) Received: from airbuntu.. (host81-157-90-255.range81-157.btcentralplus.com. [81.157.90.255]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f1f30c3ccsm4988326f8f.7.2024.06.10.12.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 12:20:21 -0700 (PDT) From: Qais Yousef To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt Cc: Vincent Guittot , Daniel Bristot de Oliveira , Thomas Gleixner , Sebastian Andrzej Siewior , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , Metin Kaya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Qais Yousef Subject: [PATCH v6 0/3] Clean up usage of rt_task() Date: Mon, 10 Jun 2024 20:20:15 +0100 Message-Id: <20240610192018.1567075-1-qyousef@layalina.io> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Make rt_task() return true only for RT class and add new realtime_task() to return true for RT and DL classes to avoid some confusion the old API can cause. No functional changes intended in patch 1. Patch 2 cleans up the return type as suggested by Steve. Patch 3 uses rt_or_dl() instead of 'realtime' as suggested by Daniel. As the name was debatable, I'll leave up to the maintainers to pick their preference. Changes since v5: * Added a new patch to s/realtime/rt_or_dl/ as suggested by Daniel. * Added Reviewed-bys. Changes since v4: * Simplify return of rt/realtime_prio() as the explicit true/false was not necessary. Changes since v3: * Make sure the 'new' bool functions return true/false instead of 1/0. * Drop patch 2 about hrtimer usage of realtime_task() as ongoing discussion on v1 indicates its scope outside of this simple cleanup. Changes since v2: * Fix one user that should use realtime_task() but remained using rt_task() (Sebastian) * New patch to convert all hrtimer users to use realtime_task_policy() (Sebastian) * Add a new patch to convert return type to bool (Steve) * Rebase on tip/sched/core and handle a conflict with code shuffle to syscalls.c * Add Reviewed-by Steve Changes since v1: * Use realtime_task_policy() instead task_has_realtime_policy() (Peter) * Improve commit message readability about replace some rt_task() users. v1 discussion: https://lore.kernel.org/lkml/20240514234112.792989-1-qyousef@layalina.io/ v2 discussion: https://lore.kernel.org/lkml/20240515220536.823145-1-qyousef@layalina.io/ v3 discussion: https://lore.kernel.org/lkml/20240527234508.1062360-1-qyousef@layalina.io/ v4 discussion: https://lore.kernel.org/lkml/20240601213309.1262206-1-qyousef@layalina.io/ v5 discussion: https://lore.kernel.org/lkml/20240604144228.1356121-1-qyousef@layalina.io/ Qais Yousef (3): sched/rt: Clean up usage of rt_task() sched/rt, dl: Convert functions to return bool sched/rt: Rename realtime_{prio, task}() to rt_or_dl_{prio, task}() fs/bcachefs/six.c | 2 +- fs/select.c | 2 +- include/linux/ioprio.h | 2 +- include/linux/sched/deadline.h | 14 ++++++------- include/linux/sched/prio.h | 1 + include/linux/sched/rt.h | 33 +++++++++++++++++++++++++------ kernel/locking/rtmutex.c | 4 ++-- kernel/locking/rwsem.c | 4 ++-- kernel/locking/ww_mutex.h | 2 +- kernel/sched/core.c | 4 ++-- kernel/sched/syscalls.c | 2 +- kernel/time/hrtimer.c | 6 +++--- kernel/trace/trace_sched_wakeup.c | 2 +- mm/page-writeback.c | 4 ++-- mm/page_alloc.c | 2 +- 15 files changed, 53 insertions(+), 31 deletions(-)