mbox series

[0/4] Remove uses of aops->writepage from gfs2

Message ID 20240719175105.788253-1-willy@infradead.org (mailing list archive)
Headers show
Series Remove uses of aops->writepage from gfs2 | expand

Message

Matthew Wilcox July 19, 2024, 5:51 p.m. UTC 
Hi Andreas,

Here's my latest attempt to switch gfs2 from ->writepage to
->writepages.  I've been a bit more careful this time; I'm not sure
whether __gfs2_writepage() could call gfs2_aspace_writepage(), but
this order of patches shouldn't break any bisection.

Matthew Wilcox (Oracle) (4):
  gfs2: Add gfs2_aspace_writepages()
  gfs2: Remove __gfs2_writepage()
  gfs2: Remove gfs2_jdata_writepage()
  gfs2: Remove gfs2_aspace_writepage()

 fs/gfs2/aops.c    | 30 ------------------------------
 fs/gfs2/log.c     | 12 ++----------
 fs/gfs2/meta_io.c | 24 +++++++++++++++++-------
 3 files changed, 19 insertions(+), 47 deletions(-)

Comments

Matthew Wilcox Aug. 7, 2024, 12:21 p.m. UTC | #1 
On Fri, Jul 19, 2024 at 06:51:00PM +0100, Matthew Wilcox (Oracle) wrote:
> Hi Andreas,
> 
> Here's my latest attempt to switch gfs2 from ->writepage to
> ->writepages.  I've been a bit more careful this time; I'm not sure
> whether __gfs2_writepage() could call gfs2_aspace_writepage(), but
> this order of patches shouldn't break any bisection.

ping

> Matthew Wilcox (Oracle) (4):
>   gfs2: Add gfs2_aspace_writepages()
>   gfs2: Remove __gfs2_writepage()
>   gfs2: Remove gfs2_jdata_writepage()
>   gfs2: Remove gfs2_aspace_writepage()
> 
>  fs/gfs2/aops.c    | 30 ------------------------------
>  fs/gfs2/log.c     | 12 ++----------
>  fs/gfs2/meta_io.c | 24 +++++++++++++++++-------
>  3 files changed, 19 insertions(+), 47 deletions(-)
> 
> -- 
> 2.43.0
>
Andreas Gruenbacher Aug. 7, 2024, 4:24 p.m. UTC | #2 
Hi Willy,

On Wed, Aug 7, 2024 at 2:21 PM Matthew Wilcox <willy@infradead.org> wrote:
> On Fri, Jul 19, 2024 at 06:51:00PM +0100, Matthew Wilcox (Oracle) wrote:
> > Hi Andreas,
> >
> > Here's my latest attempt to switch gfs2 from ->writepage to
> > ->writepages.  I've been a bit more careful this time; I'm not sure
> > whether __gfs2_writepage() could call gfs2_aspace_writepage(), but
> > this order of patches shouldn't break any bisection.
>
> ping

Thank you very much for the patches. I've had a quick look, and it
looks like they should be working now. Testing still pending, though.

Andreas

> > Matthew Wilcox (Oracle) (4):
> >   gfs2: Add gfs2_aspace_writepages()
> >   gfs2: Remove __gfs2_writepage()
> >   gfs2: Remove gfs2_jdata_writepage()
> >   gfs2: Remove gfs2_aspace_writepage()
> >
> >  fs/gfs2/aops.c    | 30 ------------------------------
> >  fs/gfs2/log.c     | 12 ++----------
> >  fs/gfs2/meta_io.c | 24 +++++++++++++++++-------
> >  3 files changed, 19 insertions(+), 47 deletions(-)
> >
> > --
> > 2.43.0
> >
>