mbox series

[v2,00/10] Convert ecryptfs to use folios

Message ID 20241025190822.1319162-1-willy@infradead.org (mailing list archive)
Headers show
Series Convert ecryptfs to use folios | expand

Message

Matthew Wilcox Oct. 25, 2024, 7:08 p.m. UTC
The next step in the folio project is to remove page->index.  This
patchset does that for ecryptfs.  As an unloved filesystem, I haven't
made any effort to support large folios; this is just "keep it working".
I have only compile tested this, but since it's a straightforward
conversion I'm not expecting any problems beyond my fat fingers.

v2:
 - Switch from 'rc' to 'err' in ecryptfs_read_folio
 - Use folio_end_read() in ecryptfs_read_folio
 - Remove kernel-doc warnings that 0day warned about
 - R-b tags from Pankaj

Matthew Wilcox (Oracle) (10):
  ecryptfs: Convert ecryptfs_writepage() to ecryptfs_writepages()
  ecryptfs: Use a folio throughout ecryptfs_read_folio()
  ecryptfs: Convert ecryptfs_copy_up_encrypted_with_header() to take a
    folio
  ecryptfs: Convert ecryptfs_read_lower_page_segment() to take a folio
  ecryptfs: Convert ecryptfs_write() to use a folio
  ecryptfs: Convert ecryptfs_write_lower_page_segment() to take a folio
  ecryptfs: Convert ecryptfs_encrypt_page() to take a folio
  ecryptfs: Convert ecryptfs_decrypt_page() to take a folio
  ecryptfs: Convert lower_offset_for_page() to take a folio
  ecryptfs: Pass the folio index to crypt_extent()

 fs/ecryptfs/crypto.c          |  35 +++++----
 fs/ecryptfs/ecryptfs_kernel.h |   9 +--
 fs/ecryptfs/mmap.c            | 136 ++++++++++++++--------------------
 fs/ecryptfs/read_write.c      |  50 ++++++-------
 4 files changed, 105 insertions(+), 125 deletions(-)

Comments

Matthew Wilcox Nov. 5, 2024, 3:01 p.m. UTC | #1
On Fri, Oct 25, 2024 at 08:08:10PM +0100, Matthew Wilcox (Oracle) wrote:
> The next step in the folio project is to remove page->index.  This
> patchset does that for ecryptfs.  As an unloved filesystem, I haven't
> made any effort to support large folios; this is just "keep it working".
> I have only compile tested this, but since it's a straightforward
> conversion I'm not expecting any problems beyond my fat fingers.
> 
> v2:
>  - Switch from 'rc' to 'err' in ecryptfs_read_folio
>  - Use folio_end_read() in ecryptfs_read_folio
>  - Remove kernel-doc warnings that 0day warned about
>  - R-b tags from Pankaj

Christian, can you take this patch series through the vfs tree?
There's been no movement on it in two weeks, and i fear it will miss the
next merge window.
Christian Brauner Nov. 5, 2024, 4:21 p.m. UTC | #2
On Fri, 25 Oct 2024 20:08:10 +0100, Matthew Wilcox (Oracle) wrote:
> The next step in the folio project is to remove page->index.  This
> patchset does that for ecryptfs.  As an unloved filesystem, I haven't
> made any effort to support large folios; this is just "keep it working".
> I have only compile tested this, but since it's a straightforward
> conversion I'm not expecting any problems beyond my fat fingers.
> 
> v2:
>  - Switch from 'rc' to 'err' in ecryptfs_read_folio
>  - Use folio_end_read() in ecryptfs_read_folio
>  - Remove kernel-doc warnings that 0day warned about
>  - R-b tags from Pankaj
> 
> [...]

I hope to be back on a regular schedule tomorrow.
I have been down with atypical pneumonia (who knows how I got that) and
have not been able to do anything for a while.

---

Applied to the vfs.ecryptfs branch of the vfs/vfs.git tree.
Patches in the vfs.ecryptfs branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.ecryptfs

[01/10] ecryptfs: Convert ecryptfs_writepage() to ecryptfs_writepages()
        https://git.kernel.org/vfs/vfs/c/807a11dab9dc
[02/10] ecryptfs: Use a folio throughout ecryptfs_read_folio()
        https://git.kernel.org/vfs/vfs/c/064fe6b4752c
[03/10] ecryptfs: Convert ecryptfs_copy_up_encrypted_with_header() to take a folio
        https://git.kernel.org/vfs/vfs/c/497eb79c3191
[04/10] ecryptfs: Convert ecryptfs_read_lower_page_segment() to take a folio
        https://git.kernel.org/vfs/vfs/c/890d477a0fcd
[05/10] ecryptfs: Convert ecryptfs_write() to use a folio
        https://git.kernel.org/vfs/vfs/c/4d3727fd065b
[06/10] ecryptfs: Convert ecryptfs_write_lower_page_segment() to take a folio
        https://git.kernel.org/vfs/vfs/c/de5ced2721f9
[07/10] ecryptfs: Convert ecryptfs_encrypt_page() to take a folio
        https://git.kernel.org/vfs/vfs/c/6b9c0e813743
[08/10] ecryptfs: Convert ecryptfs_decrypt_page() to take a folio
        https://git.kernel.org/vfs/vfs/c/c15b81461df9
[09/10] ecryptfs: Convert lower_offset_for_page() to take a folio
        https://git.kernel.org/vfs/vfs/c/bf64913dfe62
[10/10] ecryptfs: Pass the folio index to crypt_extent()
        https://git.kernel.org/vfs/vfs/c/9b4bb822448b