mbox series

[RFC,0/2] Improve simple directory offset wrap behavior

Message ID 20241117213206.1636438-1-cel@kernel.org (mailing list archive)
Headers show
Series Improve simple directory offset wrap behavior | expand

Message

Chuck Lever Nov. 17, 2024, 9:32 p.m. UTC
From: Chuck Lever <chuck.lever@oracle.com>

This series attempts to narrow some gaps in the current tmpfs
directory offset mechanism, based on misbehaviors reported by Yu
Kuai <yukuai3@huawei.com> and Yang Erkun <yangerkun@huawei.com>.

It does not fully close the window on bad behavior, as noted in
the patch description of 2/2. Perhaps discussion and review can
identify improvements that further clean up the corner cases.

The new mechanism attempts to re-use existing fields in struct
dentry rather than adding new fields, and is meant to be back
ported to LTS once it is merged upstream.

The patches currently pass xfstests, in particular generic/736.
The series has been pushed to:

https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/log/?h=nfsd-testing

Chuck Lever (2):
  libfs: Return ENOSPC when the directory offset range is exhausted
  libfs: Improve behavior when directory offset values wrap

 fs/libfs.c | 40 ++++++++++++++++++++--------------------
 1 file changed, 20 insertions(+), 20 deletions(-)

Comments

Christian Brauner Nov. 20, 2024, 9:01 a.m. UTC | #1
On Sun, 17 Nov 2024 16:32:04 -0500, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> This series attempts to narrow some gaps in the current tmpfs
> directory offset mechanism, based on misbehaviors reported by Yu
> Kuai <yukuai3@huawei.com> and Yang Erkun <yangerkun@huawei.com>.
> 
> It does not fully close the window on bad behavior, as noted in
> the patch description of 2/2. Perhaps discussion and review can
> identify improvements that further clean up the corner cases.
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/2] libfs: Return ENOSPC when the directory offset range is exhausted
      https://git.kernel.org/vfs/vfs/c/7f82c425d13b
[2/2] libfs: Improve behavior when directory offset values wrap
      https://git.kernel.org/vfs/vfs/c/3e8dd5a7404a