[0/8] More GFS2 folio conversions

Message

Matthew Wilcox Feb. 10, 2025, 1:34 p.m. UTC

I think this may be the last batch of patches to gfs2 for folio
conversions.  The only remaining references to struct page that I see are
for filesystem metadata that isn't stored in the page cache, so those are
fine to continue using struct page.  The only mild improvement would be if
we could have different bio completion handlers for gfs2_end_log_write()
when it's using mempool pages vs folio pages, but that may not even be
feasible and I like the current solution well enough.

This all seems fairly straightforward to me, but as usual only
compile-tested.  I don't anticipate the change to buffer_head.h to have
any conflicts; removing the last user of page_buffers() is not on the
cards for the next merge window.

Matthew Wilcox (Oracle) (8):
  gfs2: Use b_folio in gfs2_log_write_bh()
  gfs2: Use b_folio in gfs2_trans_add_meta()
  gfs2: Use b_folio in gfs2_submit_bhs()
  gfs2: Use b_folio in gfs2_check_magic()
  gfs2: Convert gfs2_jhead_pg_srch() to gfs2_jhead_folio_srch()
  gfs2: Convert gfs2_find_jhead() to use a folio
  gfs2: Convert gfs2_end_log_write_bh() to work on a folio
  gfs2: Convert gfs2_meta_read_endio() to use a folio

 fs/gfs2/lops.c              | 69 ++++++++++++++++++-------------------
 fs/gfs2/meta_io.c           | 15 ++++----
 fs/gfs2/trans.c             |  4 +--
 include/linux/buffer_head.h |  1 -
 4 files changed, 43 insertions(+), 46 deletions(-)

Comments

Matthew Wilcox Feb. 20, 2025, 1:51 p.m. UTC | #1

On Mon, Feb 10, 2025 at 01:34:38PM +0000, Matthew Wilcox (Oracle) wrote:
> I think this may be the last batch of patches to gfs2 for folio
> conversions.  The only remaining references to struct page that I see are
> for filesystem metadata that isn't stored in the page cache, so those are
> fine to continue using struct page.  The only mild improvement would be if
> we could have different bio completion handlers for gfs2_end_log_write()
> when it's using mempool pages vs folio pages, but that may not even be
> feasible and I like the current solution well enough.
> 
> This all seems fairly straightforward to me, but as usual only
> compile-tested.  I don't anticipate the change to buffer_head.h to have
> any conflicts; removing the last user of page_buffers() is not on the
> cards for the next merge window.

ping