[PATCHv2,0/9] ext4: fast_commit fixes, stricter block checking & cleanups

Message

Ritesh Harjani Feb. 16, 2022, 7:02 a.m. UTC

Hello,

Please find the v2 of this patch series which addresses the review comments from
Jan on PATCH-2 & PATCH-7. No changes other than that.

Summary
========
This patch series aimes at fixing some of the issues identified in fast_commit
with flex_bg. This also adds some stricter checking of blocks to be freed in
ext4_mb_clear_bb(), ext4_group_add_blocks() & ext4_mb_mark_bb()

Testing
=========
I have run xfstests with -g log,metadata,auto group with 4k & 4k_fc
configs. I have not found any regression due to these patches alone.

But I have found few issues like generic/047 occasionally failing even w/o this
patch series. I do have some fixes for those too in my tree. I will send those
fixes later after figuring out few more things around couple other failures.


References
===========
[v1]: https://lore.kernel.org/all/[e-mail]/
[RFC]: https://lore.kernel.org/all/[e-mail]/

Ritesh Harjani (9):
  ext4: Correct cluster len and clusters changed accounting in ext4_mb_mark_bb
  ext4: Fixes ext4_mb_mark_bb() with flex_bg with fast_commit
  ext4: Refactor ext4_free_blocks() to pull out ext4_mb_clear_bb()
  ext4: Use in_range() for range checking in ext4_fc_replay_check_excluded
  ext4: Rename ext4_set_bits to mb_set_bits
  ext4: No need to test for block bitmap bits in ext4_mb_mark_bb()
  ext4: Add ext4_sb_block_valid() refactored out of ext4_inode_block_valid()
  ext4: Add strict range checks while freeing blocks
  ext4: Add extra check in ext4_mb_mark_bb() to prevent against possible corruption

 fs/ext4/block_validity.c |  26 +--
 fs/ext4/ext4.h           |   5 +-
 fs/ext4/fast_commit.c    |   4 +-
 fs/ext4/mballoc.c        | 342 ++++++++++++++++++++++-----------------
 fs/ext4/resize.c         |   4 +-
 5 files changed, 220 insertions(+), 161 deletions(-)

--
2.31.1

Comments

Theodore Ts'o March 3, 2022, 12:41 a.m. UTC | #1

On Wed, 16 Feb 2022 12:32:42 +0530, Ritesh Harjani wrote:
> Please find the v2 of this patch series which addresses the review comments from
> Jan on PATCH-2 & PATCH-7. No changes other than that.
> 
> Summary
> ========
> This patch series aimes at fixing some of the issues identified in fast_commit
> with flex_bg. This also adds some stricter checking of blocks to be freed in
> ext4_mb_clear_bb(), ext4_group_add_blocks() & ext4_mb_mark_bb()
> 
> [...]

Applied, thanks!

[1/9] ext4: Correct cluster len and clusters changed accounting in ext4_mb_mark_bb
      commit: a5c0e2fdf7cea535ba03259894dc184e5a4c2800
[2/9] ext4: Fixes ext4_mb_mark_bb() with flex_bg with fast_commit
      commit: bfdc502a4a4c058bf4cbb1df0c297761d528f54d
[3/9] ext4: Refactor ext4_free_blocks() to pull out ext4_mb_clear_bb()
      commit: 8ac3939db99f99667b8eb670cf4baf292896e72d
[4/9] ext4: Use in_range() for range checking in ext4_fc_replay_check_excluded
      commit: dbaafbadc5c3dad4010099d0ff135204a8dbff49
[5/9] ext4: Rename ext4_set_bits to mb_set_bits
      commit: 123e3016ee9b3674a819537bc4c3174e25cd48fc
[6/9] ext4: No need to test for block bitmap bits in ext4_mb_mark_bb()
      commit: bd8247eee1a2b22e2270b3933ab8dca9316b3718
[7/9] ext4: Add ext4_sb_block_valid() refactored out of ext4_inode_block_valid()
      commit: 6bc6c2bdf1baca6522b8d9ba976257d722423085
[8/9] ext4: Add strict range checks while freeing blocks
      commit: a00b482b82fb098956a5bed22bd7873e56f152f1
[9/9] ext4: Add extra check in ext4_mb_mark_bb() to prevent against possible corruption
      commit: 8c91c57907d3ad8f88a12097213bb0920eb453b8

Best regards,