[0/5] fs/ntfs3: Bugfix

Message

Konstantin Komarov Jan. 29, 2024, 8:06 a.m. UTC

This series contains various fixes for ntfs3.

Konstantin Komarov (5):
   fs/ntfs3: Prevent generic message "attempt to access beyond end of
     device"
   fs/ntfs3: Use i_size_read and i_size_write
   fs/ntfs3: Correct function is_rst_area_valid
   fs/ntfs3: Fixed overflow check in mi_enum_attr()
   fs/ntfs3: Update inode->i_size after success write into compressed
     file

  fs/ntfs3/attrib.c  |  4 ++--
  fs/ntfs3/dir.c     |  2 +-
  fs/ntfs3/file.c    | 13 ++++++++-----
  fs/ntfs3/frecord.c | 10 +++++-----
  fs/ntfs3/fslog.c   | 14 ++++++++------
  fs/ntfs3/fsntfs.c  | 24 ++++++++++++++++++++++++
  fs/ntfs3/index.c   |  8 ++++----
  fs/ntfs3/inode.c   |  2 +-
  fs/ntfs3/ntfs_fs.h | 14 +-------------
  fs/ntfs3/record.c  |  2 +-
  10 files changed, 55 insertions(+), 38 deletions(-)

Comments

Thorsten Leemhuis Feb. 11, 2024, 12:31 p.m. UTC | #1

On 29.01.24 09:06, Konstantin Komarov wrote:
> 
> This series contains various fixes for ntfs3.
> 
> Konstantin Komarov (5):
>   fs/ntfs3: Prevent generic message "attempt to access beyond end of
>     device"
>   fs/ntfs3: Use i_size_read and i_size_write
>   fs/ntfs3: Correct function is_rst_area_valid
>   fs/ntfs3: Fixed overflow check in mi_enum_attr()
>   fs/ntfs3: Update inode->i_size after success write into compressed
>     file

Thx for working on these patches that recently hit mainline.

The last patch listed above afaics (I might be wrong there!) is a fix
for https://bugzilla.kernel.org/show_bug.cgi?id=218180 (~"data added to
a newly created file that uses compression only becomes visible after a
remount or a forced cache drop"). That regression from the 6.2 days
sounds somewhat concerning, hence allow me to ask: do you plan to submit
this fix for backporting to the 6.7.y and 6.6.y series? If not: do you
think it should be save to include those there?

Side not, while at it: are any of the other patches maybe also worth
backporting?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.