diff mbox

xfsprog: xfsio: update xfs_io manpage for FALLOC_FL_INSERT_RANGE

Message ID 001f01d041cb$39fbbc70$adf33550$@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Namjae Jeon Feb. 6, 2015, 5:10 a.m. UTC
Update xfs_io manpage for FALLOC_FL_INSERT_RANGE.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
---
 man/man8/xfs_io.8 | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Eric Sandeen Feb. 6, 2015, 5:26 a.m. UTC | #1
On 2/5/15 11:10 PM, Namjae Jeon wrote:
> Update xfs_io manpage for FALLOC_FL_INSERT_RANGE.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
> ---
>  man/man8/xfs_io.8 | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> index cf27b99..416206f 100644
> --- a/man/man8/xfs_io.8
> +++ b/man/man8/xfs_io.8
> @@ -404,6 +404,11 @@ Call fallocate with FALLOC_FL_COLLAPSE_RANGE flag as described in the
>  manual page to de-allocates blocks and eliminates the hole created in this process
>  by shifting data blocks into the hole.
>  .TP
> +.BI finsert " offset length"
> +Call fallocate with FALLOC_FL_INSERT_RANGE flag as described in the
> +.BR fallocate (2)
> +manual page 

So, it looks like the fallocate(2) manpage will need an update as well.  :)
(linux-man@vger.kernel.org I believe)

Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Namjae Jeon Feb. 6, 2015, 5:39 a.m. UTC | #2
> On 2/5/15 11:10 PM, Namjae Jeon wrote:
> > Update xfs_io manpage for FALLOC_FL_INSERT_RANGE.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
> > ---
> >  man/man8/xfs_io.8 | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> > index cf27b99..416206f 100644
> > --- a/man/man8/xfs_io.8
> > +++ b/man/man8/xfs_io.8
> > @@ -404,6 +404,11 @@ Call fallocate with FALLOC_FL_COLLAPSE_RANGE flag as described in the
> >  manual page to de-allocates blocks and eliminates the hole created in this process
> >  by shifting data blocks into the hole.
> >  .TP
> > +.BI finsert " offset length"
> > +Call fallocate with FALLOC_FL_INSERT_RANGE flag as described in the
> > +.BR fallocate (2)
> > +manual page
> 
Hi Eric,
> So, it looks like the fallocate(2) manpage will need an update as well.  :)
Right, I am planning to send the manpage patch for insert range when merging linus tree..

> (linux-man@vger.kernel.org I believe)
Okay.

Thanks for your point :)
> 
> Thanks,
> -Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dave Chinner Feb. 6, 2015, 10:22 p.m. UTC | #3
On Fri, Feb 06, 2015 at 02:39:56PM +0900, Namjae Jeon wrote:
> > On 2/5/15 11:10 PM, Namjae Jeon wrote:
> > > Update xfs_io manpage for FALLOC_FL_INSERT_RANGE.
> > >
> > > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > > Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
> > > ---
> > >  man/man8/xfs_io.8 | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> > > index cf27b99..416206f 100644
> > > --- a/man/man8/xfs_io.8
> > > +++ b/man/man8/xfs_io.8
> > > @@ -404,6 +404,11 @@ Call fallocate with FALLOC_FL_COLLAPSE_RANGE flag as described in the
> > >  manual page to de-allocates blocks and eliminates the hole created in this process
> > >  by shifting data blocks into the hole.
> > >  .TP
> > > +.BI finsert " offset length"
> > > +Call fallocate with FALLOC_FL_INSERT_RANGE flag as described in the
> > > +.BR fallocate (2)
> > > +manual page
> > 
> Hi Eric,
> > So, it looks like the fallocate(2) manpage will need an update as well.  :)
> Right, I am planning to send the manpage patch for insert range when merging linus tree..

Best to have the man page with the rest of the code changes, that
way they all get reviewed at the same time. :)

Cheers,

Dave.
Namjae Jeon Feb. 8, 2015, 11:41 p.m. UTC | #4
> On Fri, Feb 06, 2015 at 02:39:56PM +0900, Namjae Jeon wrote:
> > > On 2/5/15 11:10 PM, Namjae Jeon wrote:
> > > > Update xfs_io manpage for FALLOC_FL_INSERT_RANGE.
> > > >
> > > > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > > > Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
> > > > ---
> > > >  man/man8/xfs_io.8 | 5 +++++
> > > >  1 file changed, 5 insertions(+)
> > > >
> > > > diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> > > > index cf27b99..416206f 100644
> > > > --- a/man/man8/xfs_io.8
> > > > +++ b/man/man8/xfs_io.8
> > > > @@ -404,6 +404,11 @@ Call fallocate with FALLOC_FL_COLLAPSE_RANGE flag as described in the
> > > >  manual page to de-allocates blocks and eliminates the hole created in this process
> > > >  by shifting data blocks into the hole.
> > > >  .TP
> > > > +.BI finsert " offset length"
> > > > +Call fallocate with FALLOC_FL_INSERT_RANGE flag as described in the
> > > > +.BR fallocate (2)
> > > > +manual page
> > >
> > Hi Eric,
> > > So, it looks like the fallocate(2) manpage will need an update as well.  :)
> > Right, I am planning to send the manpage patch for insert range when merging linus tree..
> 
> Best to have the man page with the rest of the code changes, that
> way they all get reviewed at the same time. :)
Agree. I will also send the manpage patch soon.

Thanks :)
> 
> Cheers,
> 
> Dave.
> --
> Dave Chinner
> david@fromorbit.com

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
index cf27b99..416206f 100644
--- a/man/man8/xfs_io.8
+++ b/man/man8/xfs_io.8
@@ -404,6 +404,11 @@  Call fallocate with FALLOC_FL_COLLAPSE_RANGE flag as described in the
 manual page to de-allocates blocks and eliminates the hole created in this process
 by shifting data blocks into the hole.
 .TP
+.BI finsert " offset length"
+Call fallocate with FALLOC_FL_INSERT_RANGE flag as described in the
+.BR fallocate (2)
+manual page to create the hole by shifting data blocks.
+.TP
 .BI fpunch " offset length"
 Punches (de-allocates) blocks in the file by calling fallocate with 
 the FALLOC_FL_PUNCH_HOLE flag as described in the