From patchwork Fri Apr 24 10:07:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Firo Yang X-Patchwork-Id: 6267451 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0E6919F313 for ; Fri, 24 Apr 2015 10:08:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4D935202BE for ; Fri, 24 Apr 2015 10:08:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40368202A1 for ; Fri, 24 Apr 2015 10:08:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752817AbbDXKIf (ORCPT ); Fri, 24 Apr 2015 06:08:35 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:33703 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752802AbbDXKIc (ORCPT ); Fri, 24 Apr 2015 06:08:32 -0400 Received: by pdbnk13 with SMTP id nk13so44890591pdb.0; Fri, 24 Apr 2015 03:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=JZkGa6b4Ysn6CIlokRBgq7Dn6l2lif8A8oJgU5Q0aF8=; b=q76e4RFxxTFhOTDYZHDnGWo0S5NKVadv071vagkh/jgSA22nCNGSx7g2Cm/eJBZSGZ pAeGh4SQcaXmcILPiThzEU8v7P3ZsBOI5a8c0lc6+UbSk/egn9LzX4/EwwNEC2btOvZR gyJ9k+9t0c25QugRqtoLraOMgFfFUfXr2cZ23AAhZ8gGtYm+mDwklVx18hAd3PLk/KcB Pf+qATLp6w2VYwfAMZf1wgnGThiPGNMJ/l64cNK4dYBE1poLc9ILVRWv85pu5JqNnvD0 bUgTSz84PdxbEhX6Soo1FlE1M69cL9R9NScqpm2AnUcY8c/CBE2xPRDA1tF0mCmQRwe7 sLNw== X-Received: by 10.70.49.229 with SMTP id x5mr4705387pdn.81.1429870111300; Fri, 24 Apr 2015 03:08:31 -0700 (PDT) Received: from localhost (138.128.195.217.16clouds.com. [138.128.195.217]) by mx.google.com with ESMTPSA id nn6sm10638097pdb.79.2015.04.24.03.08.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Apr 2015 03:08:30 -0700 (PDT) From: Firo Yang To: viro@zeniv.linux.org.uk Cc: kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org, Firo Yang Subject: [PATCH] fs/compat: remove redundant 'less than zero' check Date: Fri, 24 Apr 2015 18:07:50 +0800 Message-Id: <1429870070-30310-1-git-send-email-firogm@gmail.com> X-Mailer: git-send-email 2.1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Smatch complains about the check in compat.c. fs/compat.c:565 compat_rw_copy_check_uvector() warn: unsigned 'nr_segs' is never less than zero. I think, there is no reason to check if the value nr_segs is less than zero. So I removed it. Signed-off-by: Firo Yang --- fs/compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/compat.c b/fs/compat.c index 6fd272d..beaf15b 100644 --- a/fs/compat.c +++ b/fs/compat.c @@ -562,7 +562,7 @@ ssize_t compat_rw_copy_check_uvector(int type, goto out; ret = -EINVAL; - if (nr_segs > UIO_MAXIOV || nr_segs < 0) + if (nr_segs > UIO_MAXIOV) goto out; if (nr_segs > fast_segs) { ret = -ENOMEM;