| Message ID | 1429904462-16998-2-git-send-email-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Christoph Hellwig <hch@lst.de> writes: > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h > index c2ee937..b0a5bff 100644 > --- a/include/linux/blk_types.h > +++ b/include/linux/blk_types.h > @@ -112,8 +112,6 @@ struct bio { > * bio flags > */ > #define BIO_UPTODATE 0 /* ok after I/O completion */ > -#define BIO_RW_BLOCK 1 /* RW_AHEAD set, and read/write would block */ > -#define BIO_EOF 2 /* out-out-bounds error */ > #define BIO_SEG_VALID 3 /* bi_phys_segments valid */ > #define BIO_CLONED 4 /* doesn't own data */ > #define BIO_BOUNCED 5 /* bio is a bounce bio */ Any particular reason you elected to leave a hole in the numbering? I don't have a preference either way, but I don't think there's any harm in compressing it. -Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 24, 2015 at 03:47:37PM -0400, Jeff Moyer wrote: > Any particular reason you elected to leave a hole in the numbering? I > don't have a preference either way, but I don't think there's any harm > in compressing it. This was the simplest way to do it and I'm a lazy bastard. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Christoph Hellwig <hch@lst.de> writes: > On Fri, Apr 24, 2015 at 03:47:37PM -0400, Jeff Moyer wrote: >> Any particular reason you elected to leave a hole in the numbering? I >> don't have a preference either way, but I don't think there's any harm >> in compressing it. > > This was the simplest way to do it and I'm a lazy bastard. Heh. /me looks at hch's contributions... You have a rather broad definition of lazy. :-) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 24, 2015 at 09:41:02PM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> Thanks.
diff --git a/block/blk-core.c b/block/blk-core.c index 57da507..4085265 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1716,8 +1716,6 @@ static void handle_bad_sector(struct bio *bio) bio->bi_rw, (unsigned long long)bio_end_sector(bio), (long long)(i_size_read(bio->bi_bdev->bd_inode) >> 9)); - - set_bit(BIO_EOF, &bio->bi_flags); } #ifdef CONFIG_FAIL_MAKE_REQUEST diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index c2ee937..b0a5bff 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -112,8 +112,6 @@ struct bio { * bio flags */ #define BIO_UPTODATE 0 /* ok after I/O completion */ -#define BIO_RW_BLOCK 1 /* RW_AHEAD set, and read/write would block */ -#define BIO_EOF 2 /* out-out-bounds error */ #define BIO_SEG_VALID 3 /* bi_phys_segments valid */ #define BIO_CLONED 4 /* doesn't own data */ #define BIO_BOUNCED 5 /* bio is a bounce bio */
Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/blk-core.c | 2 -- include/linux/blk_types.h | 2 -- 2 files changed, 4 deletions(-)