| Message ID | 1435319912-4335-1-git-send-email-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/26/2015 05:58 AM, Geert Uytterhoeven wrote: > With gcc 3.4.6/4.1.2/4.2.4 (not with 4.4.7/4.6.4/4.8.4): > > CC fs/block_dev.o > include/linux/fs.h:804: warning: ‘I_BDEV’ declared inline after being called > include/linux/fs.h:804: warning: previous declaration of ‘I_BDEV’ was here > > Commit a212b105b07d75b4 ("bdi: make inode_to_bdi() inline") added a > caller of I_BDEV() in a header file, exposing the bogus "inline" on the > exported implementation. > > Drop the "inline" keyword to fix this. Added, thanks.
diff --git a/fs/block_dev.c b/fs/block_dev.c index f04c873a7365c1b5..f839c339565e73af 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -43,7 +43,7 @@ static inline struct bdev_inode *BDEV_I(struct inode *inode) return container_of(inode, struct bdev_inode, vfs_inode); } -inline struct block_device *I_BDEV(struct inode *inode) +struct block_device *I_BDEV(struct inode *inode) { return &BDEV_I(inode)->bdev; }
With gcc 3.4.6/4.1.2/4.2.4 (not with 4.4.7/4.6.4/4.8.4): CC fs/block_dev.o include/linux/fs.h:804: warning: ‘I_BDEV’ declared inline after being called include/linux/fs.h:804: warning: previous declaration of ‘I_BDEV’ was here Commit a212b105b07d75b4 ("bdi: make inode_to_bdi() inline") added a caller of I_BDEV() in a header file, exposing the bogus "inline" on the exported implementation. Drop the "inline" keyword to fix this. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- fs/block_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)