From patchwork Wed Dec 2 15:40:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seth Forshee X-Patchwork-Id: 7747941 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E6BECBEEE1 for ; Wed, 2 Dec 2015 15:46:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2AF4A2050E for ; Wed, 2 Dec 2015 15:46:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 539B6204E0 for ; Wed, 2 Dec 2015 15:46:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932840AbbLBPqx (ORCPT ); Wed, 2 Dec 2015 10:46:53 -0500 Received: from mail-io0-f182.google.com ([209.85.223.182]:36473 "EHLO mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932832AbbLBPmX (ORCPT ); Wed, 2 Dec 2015 10:42:23 -0500 Received: by iofh3 with SMTP id h3so49558857iof.3 for ; Wed, 02 Dec 2015 07:42:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9sEaxXAG+7QGiN3WXMDGRRt6jScXk5CShjajDsCHZAU=; b=F4asSwPdE+5x1TMTLrlAVadz2bVu7RzCnu9pcR6PQD45BoMdYggtLA5xGUj071dDN9 INRes0zX7oFHZsBW6d7QTQeJnDexJ+/N+YiU9M3dOvLFaeJvvXSDH19pScTeVky6Ttf7 C/A4DFop374qeostz7IO1VFlyMOsYHY67yxZHMQ0qRGhkvpvtENkL0sF5RDbz3l2sZVj 9kLGSzn+TeWuwbG+K3NtB/49axwcMEKjODk7OOUNm8w+SaLSiRAEYCkB4TiHUXBJ7vzd 8rA40hgALPkEvkGNsqRqz7v32y0j5Ct+X5SI0whij3qaRYTzJQd5UQADrW9LwvBtWKxH Ayhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9sEaxXAG+7QGiN3WXMDGRRt6jScXk5CShjajDsCHZAU=; b=BTKx9XIh4XPPVJ8Sk9xHFME09oqPRc6FE19qrrdD4NyURlEctzdecVQAhqFOUPktYI y20cUQZAT5FKlCaiXR9PXufLbi8pV5rU3JChruSFwkC73+t2tKklCpX7nxcL3vUmZaQu ShaNwQsUMqfk6AntzZyDPDZP6nehUDs48LS4dc8kMN+O7ePy7uUTor02bbZeqNG9GTP5 7BhA0SP1CTpL13Sj/QOTGdJsnfA7nmqJE/NrgdfyzOpAcSq7yLwE11FKMK/lLO8oM6f9 SpnVbH3rJ7/HJ1vCx/jk18hsroQxMXXOheXfSIUhU9TdZvGJl7+Ml9rsxeyCH8EaYsfH YBbw== X-Gm-Message-State: ALoCoQlz+zc3Cmj7VVuRRS1H5FCnXO8fkymHwXN4DnQ3vfTUrqvuuaCqt8w1aLYVoznypSeSwouS X-Received: by 10.107.4.213 with SMTP id 204mr4800058ioe.195.1449070942523; Wed, 02 Dec 2015 07:42:22 -0800 (PST) Received: from localhost (199-87-125-144.dyn.kc.surewest.net. [199.87.125.144]) by smtp.gmail.com with ESMTPSA id t98sm1351062ioi.31.2015.12.02.07.42.21 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 02 Dec 2015 07:42:22 -0800 (PST) From: Seth Forshee To: "Eric W. Biederman" Cc: Alexander Viro , Serge Hallyn , Richard Weinberger , Austin S Hemmelgarn , Miklos Szeredi , linux-bcache@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, fuse-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Seth Forshee Subject: [PATCH 08/19] cred: Reject inodes with invalid ids in set_create_file_as() Date: Wed, 2 Dec 2015 09:40:08 -0600 Message-Id: <1449070821-73820-9-git-send-email-seth.forshee@canonical.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1449070821-73820-1-git-send-email-seth.forshee@canonical.com> References: <1449070821-73820-1-git-send-email-seth.forshee@canonical.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using INVALID_[UG]ID for the LSM file creation context doesn't make sense, so return an error if the inode passed to set_create_file_as() has an invalid id. Signed-off-by: Seth Forshee Acked-by: Serge Hallyn --- kernel/cred.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/cred.c b/kernel/cred.c index 71179a09c1d6..ff8606f77d90 100644 --- a/kernel/cred.c +++ b/kernel/cred.c @@ -689,6 +689,8 @@ EXPORT_SYMBOL(set_security_override_from_ctx); */ int set_create_files_as(struct cred *new, struct inode *inode) { + if (!uid_valid(inode->i_uid) || !gid_valid(inode->i_gid)) + return -EINVAL; new->fsuid = inode->i_uid; new->fsgid = inode->i_gid; return security_kernel_create_files_as(new, inode);