From patchwork Fri Jun 10 14:46:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Krzysztof_B=C5=82aszkowski?= X-Patchwork-Id: 9169965 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 55084604DB for ; Fri, 10 Jun 2016 14:46:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 44B1328363 for ; Fri, 10 Jun 2016 14:46:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 39A6128368; Fri, 10 Jun 2016 14:46:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1246128367 for ; Fri, 10 Jun 2016 14:46:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752222AbcFJOqu (ORCPT ); Fri, 10 Jun 2016 10:46:50 -0400 Received: from k22.active24.pl ([195.78.67.22]:40284 "EHLO k22.active24.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbcFJOqt (ORCPT ); Fri, 10 Jun 2016 10:46:49 -0400 Received: from amavis.k22.active24.pl (localhost [127.0.0.1]) by k22.active24.pl (Postfix) with ESMTP id 3rR4kZ2QwPzDnrY; Fri, 10 Jun 2016 16:46:46 +0200 (CEST) X-Virus-Scanned: amavisd-new at k22.active24.pl Received: from k22.active24.pl ([127.0.0.1]) by amavis.k22.active24.pl (k22.active24.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Npb-fF39r45W; Fri, 10 Jun 2016 16:46:46 +0200 (CEST) Received: from [192.168.208.2] (89-79-49-185.dynamic.chello.pl [89.79.49.185]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: kb@sysmikro.com.pl) by k22.active24.pl (Postfix) with ESMTPSA id 3rR4kY1F5VzDnrR; Fri, 10 Jun 2016 16:46:44 +0200 (CEST) Subject: Re: freevxfs: hp-ux support. ( 1cce17017970c07) patchset 1/4 From: Krzysztof =?UTF-8?Q?B=C5=82aszkowski?= To: Christoph Hellwig Cc: Carlos Maiolino , linux-fsdevel@vger.kernel.org In-Reply-To: <20160602082518.GB12071@infradead.org> References: <1464273946.17980.15.camel@linux-q3cb.site> <1464464428.3689.14.camel@linux-q3cb.site> <20160531122510.GA25651@infradead.org> <1464702291.900.75.camel@linux-q3cb.site> <20160601073310.GA6787@infradead.org> <1464773012.900.105.camel@linux-q3cb.site> <20160602082518.GB12071@infradead.org> Organization: Systemy mikroprocesorowe Date: Fri, 10 Jun 2016 16:46:43 +0200 Message-ID: <1465570003.5573.22.camel@linux-q3cb.site> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Christoph, Here are these kfree()s. From e82e484492af7a66b25510718783529bad345cfc Mon Sep 17 00:00:00 2001 From: KB Date: Fri, 10 Jun 2016 09:52:19 +0200 Subject: [PATCH 1/4] vxfs_read_fshead() memory leak fixed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit every successful mount two structs vxfs_fsh were not released Signed-off-by: Krzysztof Błaszkowski --- fs/freevxfs/vxfs_fshead.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/freevxfs/vxfs_fshead.c b/fs/freevxfs/vxfs_fshead.c index 69a10d6..a4610a7 100644 --- a/fs/freevxfs/vxfs_fshead.c +++ b/fs/freevxfs/vxfs_fshead.c @@ -172,6 +172,8 @@ vxfs_read_fshead(struct super_block *sbp) goto out_iput_ilist; } + kfree(pfp); + kfree(sfp); return 0; out_iput_ilist: