From patchwork Tue Jul 12 21:27:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Pitre X-Patchwork-Id: 9226271 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DEB47608A7 for ; Tue, 12 Jul 2016 21:44:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D4D7E27165 for ; Tue, 12 Jul 2016 21:44:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D379027F9E; Tue, 12 Jul 2016 21:44:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75B7927165 for ; Tue, 12 Jul 2016 21:44:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbcGLVnn (ORCPT ); Tue, 12 Jul 2016 17:43:43 -0400 Received: from alt13.smtp-out.videotron.ca ([135.19.0.26]:58711 "EHLO alt12.smtp-out.videotron.ca" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752000AbcGLVnl (ORCPT ); Tue, 12 Jul 2016 17:43:41 -0400 Received: from yoda.home ([96.23.157.65]) by Videotron with SMTP id N5DlbMCogHh2dN5DmbGOUZ; Tue, 12 Jul 2016 17:28:02 -0400 X-Authority-Analysis: v=2.1 cv=Lv0ysipc c=1 sm=1 tr=0 a=keA3yYpnlypCNW5BNWqu+w==:117 a=keA3yYpnlypCNW5BNWqu+w==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=cAmyUtKerLwA:10 a=KKAkSRfTAAAA:8 a=6cg3P4PxVmMxiyGXiDwA:9 a=cvBusfyB2V15izCimMoJ:22 Received: from xanadu.home (xanadu.home [192.168.2.2]) by yoda.home (Postfix) with ESMTP id 3F8E52DA0684; Tue, 12 Jul 2016 17:28:00 -0400 (EDT) From: Nicolas Pitre To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alexander Viro , David Howells , Greg Ungerer Subject: [PATCH 06/10] binfmt_flat: use proper user space accessors with old relocs code Date: Tue, 12 Jul 2016 17:27:38 -0400 Message-Id: <1468358862-11799-7-git-send-email-nicolas.pitre@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1468358862-11799-1-git-send-email-nicolas.pitre@linaro.org> References: <1468358862-11799-1-git-send-email-nicolas.pitre@linaro.org> X-CMAE-Envelope: MS4wfAB8j0WcIslFsrmI9/Q96aUi342hawgpO8LezKIfD1/AJS026IHM1MUHemzVoIqw8Byl6Ri564YqCyyRjxC13t4DlDS0ofNPEligMAL/mD5sL9BHy2mo p2POtHVCcpjGmNPlh9+hgrek0L2f3CEaoO/Kz+ogA/rBmeWz0jLUcwBpupoXezxIynlX4y+jHu8kZ1bL7UC3cRN6wUMtd58OFzEEZtKgXQb4wMEVoVLfIAIl 6BBP7MOik8b1Jmp9SSGkcd4rdt+8qcuAtkH/sqofT2fqEdsFNJR30bFQhYsQka42Hre0MAn71vlSMZh+WGTCUA== Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index fc0ee3ed5d..c85f8f1239 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -394,38 +394,41 @@ static void old_reloc(unsigned long rl) static const char *segment[] = { "TEXT", "DATA", "BSS", "*UNKNOWN*" }; #endif flat_v2_reloc_t r; - unsigned long *ptr; + unsigned long __user *ptr; + unsigned long val; r.value = rl; #if defined(CONFIG_COLDFIRE) - ptr = (unsigned long *) (current->mm->start_code + r.reloc.offset); + ptr = (unsigned long __user *)(current->mm->start_code + r.reloc.offset); #else - ptr = (unsigned long *) (current->mm->start_data + r.reloc.offset); + ptr = (unsigned long __user *)(current->mm->start_data + r.reloc.offset); #endif + __get_user(val, ptr); #ifdef DEBUG printk("Relocation of variable at DATASEG+%x " "(address %p, currently %lx) into segment %s\n", - r.reloc.offset, ptr, *ptr, segment[r.reloc.type]); + r.reloc.offset, ptr, val, segment[r.reloc.type]); #endif switch (r.reloc.type) { case OLD_FLAT_RELOC_TYPE_TEXT: - *ptr += current->mm->start_code; + val += current->mm->start_code; break; case OLD_FLAT_RELOC_TYPE_DATA: - *ptr += current->mm->start_data; + val += current->mm->start_data; break; case OLD_FLAT_RELOC_TYPE_BSS: - *ptr += current->mm->end_data; + val += current->mm->end_data; break; default: printk("BINFMT_FLAT: Unknown relocation type=%x\n", r.reloc.type); break; } + __put_user(val, ptr); #ifdef DEBUG - printk("Relocation became %lx\n", *ptr); + printk("Relocation became %lx\n", val); #endif } @@ -788,8 +791,13 @@ static int load_flat_file(struct linux_binprm * bprm, } } } else { - for (i=0; i < relocs; i++) - old_reloc(ntohl(reloc[i])); + for (i=0; i < relocs; i++) { + unsigned long relval; + if (get_user(relval, reloc + i)) + return -EFAULT; + relval = ntohl(relval); + old_reloc(relval); + } } flush_icache_range(start_code, end_code);